[RuleEngine] Attribute Locator interface, minor code refactoring

Author: vahonc

src/module-elasticsuite-catalog-optimizer/Model/Rule/Attribute/OptimizerLocationProvider.php

@@ -15,6 +15,7 @@
 namespace Smile\ElasticsuiteCatalogOptimizer\Model\Rule\Attribute;
 
 use Magento\Framework\App\ResourceConnection;
+use Smile\ElasticsuiteCatalogOptimizer\Api\Data\OptimizerInterface;
 use Smile\ElasticsuiteCatalogRule\Api\Rule\Attribute\LocationProviderInterface;
 
 /**
@@ -36,11 +37,6 @@
  */
 class OptimizerLocationProvider implements LocationProviderInterface
 {
-    /**
-     * Optimizer table name.
-     */
-    private const TABLE_NAME = 'smile_elasticsuite_optimizer';
-
     /**
      * @var ResourceConnection
      */
@@ -72,7 +68,7 @@ public function isPresent(string $attribute): bool
         }
 
         $connection = $this->resource->getConnection();
-        $tableName  = $this->resource->getTableName(self::TABLE_NAME);
+        $tableName = $this->resource->getTableName(OptimizerInterface::TABLE_NAME);
 
         /**
          * Build LIKE pattern:

src/module-elasticsuite-virtual-category/Model/Rule/Attribute/VirtualCategoryLocationProvider.php

@@ -18,6 +18,7 @@
 use Magento\Framework\App\ResourceConnection;
 use Magento\Framework\Exception\NoSuchEntityException;
 use Smile\ElasticsuiteCatalogRule\Api\Rule\Attribute\LocationProviderInterface;
+use Magento\Catalog\Api\Data\CategoryAttributeInterface;
 
 /**
  * Virtual Category Attribute Location Provider.
@@ -41,16 +42,6 @@
  */
 class VirtualCategoryLocationProvider implements LocationProviderInterface
 {
-    /**
-     * Attribute code storing virtual category rules.
-     */
-    private const ATTRIBUTE_CODE = 'virtual_rule';
-
-    /**
-     * Entity type code for categories.
-     */
-    private const ENTITY_TYPE = 'catalog_category';
-
     /**
      * @var ResourceConnection
      */
@@ -61,19 +52,27 @@ class VirtualCategoryLocationProvider implements LocationProviderInterface
      */
     private AttributeRepositoryInterface $attributeRepository;
 
+    /**
+     * @var string
+     */
+    private string $attributeCode;
+
     /**
      * Constructor.
      *
      * @param ResourceConnection           $resource            Database resource connection.
      * @param AttributeRepositoryInterface $attributeRepository Repository used to retrieve EAV attribute metadata
      *                                                          (attribute ID and backend table for virtual_rule).
+     * @param string                       $attributeCode       Attribute code used to store virtual category rules.
      */
     public function __construct(
         ResourceConnection $resource,
-        AttributeRepositoryInterface $attributeRepository
+        AttributeRepositoryInterface $attributeRepository,
+        string $attributeCode = 'virtual_rule'
     ) {
         $this->resource = $resource;
         $this->attributeRepository = $attributeRepository;
+        $this->attributeCode = $attributeCode;
     }
 
     /**
@@ -91,8 +90,8 @@ public function isPresent(string $attribute): bool
         try {
             // Load the virtual_rule attribute metadata.
             $eavAttribute = $this->attributeRepository->get(
-                self::ENTITY_TYPE,
-                self::ATTRIBUTE_CODE
+                CategoryAttributeInterface::ENTITY_TYPE_CODE,
+                $this->attributeCode
             );
         } catch (NoSuchEntityException $e) {
             // Attribute not found => cannot be used anywhere.