Fix category position migrator visibility join

using dynamic linkField (CE/Mage-OS + EE compatibility)

Author: mrrobot-magedev

src/module-elasticsuite-catalog/Model/CategoryPositionMigrator.php

@@ -23,6 +23,8 @@
 use Magento\Framework\Exception\LocalizedException;
 use Psr\Log\LoggerInterface;
 use Symfony\Component\Console\Output\OutputInterface;
+use \Magento\Catalog\Api\Data\ProductInterface;
+use Magento\Framework\EntityManager\MetadataPool;
 
 /**
  * Service class responsible for migrating product positions from Magento legacy catalog table to ElasticSuite table.
@@ -40,6 +42,7 @@
  * @category Smile
  * @package  Smile\ElasticsuiteCatalog
  * @author   Vadym Honcharuk <[email protected]>
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class CategoryPositionMigrator
 {
@@ -95,6 +98,11 @@ class CategoryPositionMigrator
      */
     private $logger;
 
+    /**
+     * @var MetadataPool
+     */
+    private $metadataPool;
+
     /**
      * Constructor.
      *
@@ -103,20 +111,23 @@ class CategoryPositionMigrator
      * @param CategoryProductResource   $categoryProductResource   Magento legacy category-product relation resource model.
      * @param Config                    $eavConfig                 Eav config.
      * @param LoggerInterface           $logger                    PSR-compliant logger for debug and error logging.
+     * @param MetadataPool              $metadataPool              Magento entity metadata pool.
      */
     public function __construct(
         ResourceConnection $resource,
         CategoryCollectionFactory $categoryCollectionFactory,
         CategoryProductResource $categoryProductResource,
         Config $eavConfig,
-        LoggerInterface $logger
+        LoggerInterface $logger,
+        MetadataPool $metadataPool
     ) {
         $this->resource = $resource;
         $this->connection = $resource->getConnection();
         $this->categoryCollectionFactory = $categoryCollectionFactory;
         $this->categoryProductResource = $categoryProductResource;
         $this->eavConfig = $eavConfig;
         $this->logger = $logger;
+        $this->metadataPool = $metadataPool;
     }
 
     /**
@@ -264,6 +275,8 @@ public function migrateCategoryPositions(
         $visibilityAttribute = $this->eavConfig->getAttribute(Product::ENTITY, 'visibility');
         $visibilityAttributeId = (int) $visibilityAttribute->getAttributeId();
 
+        $linkField = $this->metadataPool->getMetadata(ProductInterface::class)->getLinkField();
+
         $storeId = 0;
         $offset = 0;
         $migratedCount = 0;
@@ -297,7 +310,7 @@ public function migrateCategoryPositions(
                 ->from(['ccp' => $legacyTable], ['product_id', 'position'])
                 ->joinLeft(
                     ['cpei' => $visibilityTable],
-                    'cpei.row_id = ccp.product_id'
+                    'cpei.' . $linkField . ' = ccp.product_id'
                     . ' AND cpei.attribute_id = ' . $visibilityAttributeId
                     . ' AND cpei.store_id = ' . $storeId,
                     ['']