Skip to content

Commit 8b9a350

Browse files
authored
Merge pull request #143 from jhlegarreta/mnt/upgrade-python-min-version
MNT: Upgrade Python required minimum versions
2 parents 94e0dcb + 594a086 commit 8b9a350

5 files changed

Lines changed: 12 additions & 18 deletions

File tree

.github/workflows/check_format.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
strategy:
1010
matrix:
1111
os: [ubuntu-latest]
12-
python-version: [3.8]
12+
python-version: [3.12]
1313
requires: ['latest']
1414

1515
steps:

.github/workflows/test_package.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
# max-parallel: 6
1212
matrix:
1313
os: [ubuntu-latest]
14-
python-version: [3.8]
14+
python-version: ['3.12']
1515
requires: ['minimal', 'latest']
1616

1717
steps:

dmriseg/data/lut/utils.py

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -9,13 +9,7 @@
99
import importlib_resources
1010
import pandas as pd
1111
import requests
12-
from SUITPy import (
13-
fetch_buckner_2011,
14-
fetch_diedrichsen_2009,
15-
fetch_ji_2019,
16-
fetch_king_2019,
17-
fetch_xue_2021,
18-
)
12+
from SUITPy.atlas import fetch_atlas
1913
from SUITPy.utils import _fetch_files, _get_dataset_dir
2014

2115
from dmriseg._utils import fill_doc
@@ -220,15 +214,15 @@ def fetch_suit_atlas(atlas, **kwargs):
220214
_data = kwargs.pop(data_arg, _data)
221215

222216
if atlas == Atlas.BUCKNER:
223-
atlas_data = fetch_buckner_2011(**kwargs)
217+
atlas_data = fetch_atlas("Buckner_2011", **kwargs)
224218
elif atlas == Atlas.DIEDRICHSEN:
225-
atlas_data = fetch_diedrichsen_2009(**kwargs)
219+
atlas_data = fetch_atlas("Diedrichsen_2009", **kwargs)
226220
elif atlas == Atlas.JI:
227-
atlas_data = fetch_ji_2019(**kwargs)
221+
atlas_data = fetch_atlas("Ji_2019", **kwargs)
228222
elif atlas == Atlas.KING:
229-
atlas_data = fetch_king_2019(data=_data, **kwargs)
223+
atlas_data = fetch_atlas("King_2019", data=_data, **kwargs)
230224
elif atlas == Atlas.XUE:
231-
atlas_data = fetch_xue_2021(**kwargs)
225+
atlas_data = fetch_atlas("Xue_2021", **kwargs)
232226
else:
233227
raise ValueError(f"Unknown atlas name: {atlas}.")
234228

@@ -285,7 +279,7 @@ def fetch_suit_cmap_lut_files(
285279
# name matching the URL
286280
dataset_name = atlas_dirname.value.lower()
287281
data_dir = _get_dataset_dir(
288-
dataset_name, data_dir=data_dir, verbose=verbose
282+
dataset_name, atlas_dir=data_dir, verbose=verbose
289283
)
290284

291285
# Get local fullpath(s) of downloaded file(s)

dmriseg/models/tests/test_models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
def test_unet():
1010
# A full forward pass
11-
x = torch.randn(1, 32)
11+
x = torch.randn(1, 1, 32, 32)
1212
model = UNet()
1313
y = model(x)
1414

pyproject.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ dependencies = [
3434
"seg-metrics",
3535
"statannotations",
3636
"statsmodels",
37-
"SUITPy",
37+
"SUITPy @ git+https://github.com/DiedrichsenLab/SUITPy.git@728f7d9bd2d1d078800768311fb144151c2c8647",
3838
"torch",
3939
"tqdm",
4040
]
@@ -45,7 +45,7 @@ maintainers = [
4545
]
4646
name = "dmriseg"
4747
version = "0.0.1"
48-
requires-python = ">=3.8"
48+
requires-python = ">=3.10"
4949

5050

5151
[project.optional-dependencies]

0 commit comments

Comments
 (0)