enable nullable reference types across the project to improve null safety

Author: RayWangQvQ

CHANGELOG.md

@@ -1,3 +1,5 @@
+## 3.0.9
+- Feature: 开启Nullable特性，在编译阶段检查潜在的 NullReferenceException 问题
 ## 3.0.8
 - Feature[#842]: 新增新版青龙添加鉴权的说明文档
 ## 3.0.7

common.props

@@ -1,7 +1,7 @@
 <Project>
   <PropertyGroup>
     <Authors>Ray</Authors>
-    <Version>3.0.8</Version>
+    <Version>3.0.9</Version>
     <NoWarn>$(NoWarn);CS1591;CS0436</NoWarn>
   </PropertyGroup>
 </Project>

src/Ray.BiliBiliTool.Agent/Attributes/AppendHeaderAttribute.cs

@@ -1,7 +1,5 @@
-using System;
-using System.Diagnostics;
+using System.Diagnostics;
 using System.Net.Http.Headers;
-using System.Threading.Tasks;
 using WebApiClientCore;
 using WebApiClientCore.Attributes;
 
@@ -14,19 +12,19 @@ namespace Ray.BiliBiliTool.Agent.Attributes;
 )]
 public class AppendHeaderAttribute(
     string name,
-    string value,
+    string? value,
     AppendHeaderType appendHeaderType = AppendHeaderType.AddOrReplace
 ) : ApiActionAttribute, IApiParameterAttribute
 {
     //添加的顺序为：子类、基类、子类函数、子类函数入参
 
-    private readonly string _aliasName;
+    private readonly string? _aliasName;
 
     public AppendHeaderAttribute(
         string aliasName,
         AppendHeaderType appendHeaderType = AppendHeaderType.AddOrReplace
     )
-        : this(null, null, appendHeaderType)
+        : this("", null, appendHeaderType)
     {
         _aliasName = aliasName;
     }
@@ -39,13 +37,13 @@ public override Task OnRequestAsync(ApiRequestContext context)
 
     public Task OnRequestAsync(ApiParameterContext context)
     {
-        string parameterName = _aliasName;
+        var parameterName = _aliasName;
         if (string.IsNullOrEmpty(parameterName))
         {
             parameterName = context.ParameterName;
         }
 
-        string text = context.ParameterValue?.ToString();
+        var text = context.ParameterValue?.ToString();
         if (!string.IsNullOrEmpty(text))
         {
             AddByAppendType(context.HttpContext.RequestMessage.Headers, parameterName, text);
@@ -54,7 +52,7 @@ public Task OnRequestAsync(ApiParameterContext context)
         return Task.CompletedTask;
     }
 
-    private void AddByAppendType(HttpRequestHeaders headers, string key, string value)
+    private void AddByAppendType(HttpRequestHeaders headers, string key, string? value)
     {
         switch (appendHeaderType)
         {

src/Ray.BiliBiliTool.Agent/Attributes/LogFilterAttribute.cs

@@ -1,6 +1,4 @@
-using System;
-using System.Reflection;
-using System.Threading.Tasks;
+using System.Reflection;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
 using WebApiClientCore;
@@ -18,13 +16,13 @@ protected override Task WriteLogAsync(ApiResponseContext context, LogMessage log
             return Task.CompletedTask;
         }
 
-        MethodInfo member = context.ApiAction.Member;
-        var strArray = new string[5];
-        Type declaringType1 = member.DeclaringType;
-        strArray[0] = (object)declaringType1 != null ? declaringType1.Namespace : null;
+        MethodInfo member = context.ActionDescriptor.Member;
+        var strArray = new string?[5];
+        var declaringType1 = member.DeclaringType;
+        strArray[0] = declaringType1?.Namespace;
         strArray[1] = ".";
-        Type declaringType2 = member.DeclaringType;
-        strArray[2] = (object)declaringType2 != null ? declaringType2.Name : null;
+        var declaringType2 = member.DeclaringType;
+        strArray[2] = declaringType2?.Name;
         strArray[3] = ".";
         strArray[4] = member.Name;
         string categoryName = string.Concat(strArray);

src/Ray.BiliBiliTool.Agent/BiliBiliAgent/Dtos/Article/SearchArticlesByUpIdFullFto.cs

@@ -16,6 +16,6 @@ public class SearchArticlesByUpIdDto : IWrid
 
     public string platform { get; set; } = "web";
 
-    public string w_rid { get; set; }
+    public string? w_rid { get; set; }
     public long wts { get; set; }
 }

src/Ray.BiliBiliTool.Agent/BiliBiliAgent/Dtos/Article/SearchUpArticlesResponse.cs

@@ -4,13 +4,13 @@ namespace Ray.BiliBiliTool.Agent.BiliBiliAgent.Dtos.Article;
 
 public class SearchUpArticlesResponse
 {
-    public List<ArticleInfo> Articles { get; set; }
+    public List<ArticleInfo> Articles { get; set; } = [];
     public int Count { get; set; }
 }
 
 public class ArticleInfo
 {
     public long Id { get; set; }
 
-    public string Title { get; set; }
+    public required string Title { get; set; }
 }

src/Ray.BiliBiliTool.Agent/BiliBiliAgent/Dtos/BaseAppRequest.cs

@@ -26,5 +26,5 @@ public class BaseAppRequest
 
     // public long ts { get; set; }
 
-    public string sign { get; set; }
+    public string? sign { get; set; }
 }

src/Ray.BiliBiliTool.Agent/BiliBiliAgent/Dtos/BiliApiResponse.cs

@@ -6,7 +6,7 @@ public class BiliApiResponse<TData>
 {
     public int Code { get; set; } = int.MinValue;
 
-    public string Message { get; set; }
+    public string? Message { get; set; }
 
-    public TData Data { get; set; }
+    public TData? Data { get; set; }
 }

src/Ray.BiliBiliTool.Agent/BiliBiliAgent/Dtos/ChargeResponse.cs

@@ -4,7 +4,7 @@ public class ChargeResponse
 {
     public int Status { get; set; }
 
-    public string Order_no { get; set; }
+    public required string Order_no { get; set; }
 }
 
 public class ChargeV2Response

src/Ray.BiliBiliTool.Agent/BiliBiliAgent/Dtos/GetSpaceInfoFullDto.cs

@@ -6,6 +6,6 @@ public class GetSpaceInfoDto : IWrid
 {
     public long mid { get; set; }
 
-    public string w_rid { get; set; }
+    public string? w_rid { get; set; }
     public long wts { get; set; }
 }