Fix an issue where msgboxes would crash the application + Make UPnP issues not prevent calls

Author: vlOd

Pinto.sln

@@ -5,8 +5,6 @@ VisualStudioVersion = 16.0.33529.622
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Pinto", "Pinto\Pinto.csproj", "{3C666CE0-2F98-4C12-8B7D-AF1AFC5480B8}"
 EndProject
-Project("{54435603-DBB4-11D2-8724-00A0C9A8B90C}") = "PintoSetup", "PintoSetup\PintoSetup.vdproj", "{FA82007F-4B1C-4E32-ACE1-5376DBF39028}"
-EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Build|x64 = Build|x64
@@ -17,8 +15,6 @@ Global
 		{3C666CE0-2F98-4C12-8B7D-AF1AFC5480B8}.Build|x64.Build.0 = Build|x64
 		{3C666CE0-2F98-4C12-8B7D-AF1AFC5480B8}.Build|x86.ActiveCfg = Build|x86
 		{3C666CE0-2F98-4C12-8B7D-AF1AFC5480B8}.Build|x86.Build.0 = Build|x86
-		{FA82007F-4B1C-4E32-ACE1-5376DBF39028}.Build|x64.ActiveCfg = Build
-		{FA82007F-4B1C-4E32-ACE1-5376DBF39028}.Build|x86.ActiveCfg = Build
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE

Pinto/Forms/CallManager.cs

@@ -120,10 +120,20 @@ private void Start(string ip)
                             "Warning", MessageBoxButtons.OK, MessageBoxIcon.Warning);
                     else
                     {
-                        routerMapping = router.StaticPortMappingCollection.Add(PORT, "UDP",
-                            PORT, GetAllLocalIPv4(NetworkInterfaceType.Ethernet)
-                                .FirstOrDefault(), true, "UDPAudio");
-                        lExternalIP.Text = $"External IP: {routerMapping.ExternalIPAddress}";
+                        try
+                        {
+                            routerMapping = router.StaticPortMappingCollection.Add(PORT, "UDP",
+                                PORT, GetAllLocalIPv4(NetworkInterfaceType.Ethernet)
+                                    .FirstOrDefault(), true, "UDPAudio");
+                            lExternalIP.Text = $"External IP: {routerMapping.ExternalIPAddress}";
+                        }
+                        catch (Exception ex) 
+                        {
+                            MessageBox.Show($"Unable to use UPnP to open the listen port:" +
+                                $"{Environment.NewLine}{ex}{Environment.NewLine}{Environment.NewLine}" +
+                                $"Please do not report this issue, as UPnP support in C# is very unstable",
+                                "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
+                        }
                     }
 
                     tCall.Start();

Pinto/Forms/MsgBox/MsgBox.cs

@@ -41,7 +41,7 @@ public static void ShowNotification(Form parent, string body, string title = "No
                     break;
             }
 
-            if (parent.WindowState != FormWindowState.Normal) parent = null;
+            if (parent != null && parent.WindowState != FormWindowState.Normal) parent = null;
             notification.StartPosition = parent == null ?
                 FormStartPosition.CenterScreen : FormStartPosition.CenterParent;
 
@@ -93,7 +93,7 @@ public static void ShowPromptNotification(Form parent, string body, string title
                     break;
             }
 
-            if (parent.WindowState != FormWindowState.Normal) parent = null;
+            if (parent != null && parent.WindowState != FormWindowState.Normal) parent = null;
             notification.StartPosition = parent == null ?
                 FormStartPosition.CenterScreen : FormStartPosition.CenterParent;
 

Pinto/Pinto.csproj

@@ -35,8 +35,7 @@
     <StartupObject />
   </PropertyGroup>
   <PropertyGroup>
-    <ApplicationIcon>
-    </ApplicationIcon>
+    <ApplicationIcon>Resources\Logo\LOGO.ico</ApplicationIcon>
   </PropertyGroup>
   <PropertyGroup />
   <PropertyGroup />

Pinto/Program.cs

@@ -13,7 +13,7 @@ namespace PintoNS
     public static class Program
     {
         public static ConsoleForm Console;
-        public const string VERSION_STRING = "exp1";
+        public const string VERSION_STRING = "exp0";
         public const int PROTOCOL_VERSION = 0;
 
         [STAThread]