K5 Compatibility

[afbora]

Hello @Pechente,

Thank you for this popular plugin that users use frequently.

Kirby 5.0 will be released soon and we see that your plugin is not yet compatible with Kirby 5.0. What is the status of you and your plugin for Kirby 5.0 compatibility? Do you have any work on it? If there is anything we can do as the Kirby team, we would be happy to do it.

Please let us know and feel free to tell us.

[Pechente]

Thanks for reaching out @afbora! I'm testing compatibility with beta 6 right now and so far it looks like there are no issues - did you see any specific bugs?

The only problem I can see, is that the admin bar is also rendered in Kirby's page preview which is not ideal. I can however not find any parameter, i.e. on the page that would tell me if the page is currently displayed as a preview. This might be a useful feature since users could also enable / disable some features like cookie banners for the preview.

[afbora]

Great 🙌 No, I haven't tested it yet. I just wanted to ask since it doesn't seem to be compatible with K5 in the directory.

[bastianallgeier]

I've tested it and it works great. I didn't see any issues with v5.

Here's a first rough idea how you could remove the admin bar in the preview. I've simply included this in the script block of the admin-bar snippet.

if (window.frameElement?.parentElement?.classList.contains("k-preview-browser") === true) {
    adminBar.remove();
}

It's a bit of a hack but works great as first step. We should definitely add a preview parameter, but we haven't decided how we are going to implement it yet. I hope we can finish this before the final release. I've created an issue: getkirby/kirby#7225

[Pechente]

@bastianallgeier Thank you for the code snippet and the issue on the Kirby repo. I saw the get parameter for pages that are loaded in the preview is already added in the newest release candidate - that was quick! As of 2.2.3 of admin bar I'm just checking for this parameter and it works really well to hide the bar in preview mode.