Skip to content

Commit 5adc225

Browse files
authored
Merge pull request #151 from OpenNMS/cg/jira/MPLUG-91
MPLUG-91: Upgrade to use integration api 2.0.0
2 parents c1204cb + 014a9b1 commit 5adc225

11 files changed

Lines changed: 31 additions & 23 deletions

File tree

.circleci/config.yml

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,13 @@ version: 2.1
33
executors:
44
build-executor:
55
docker:
6-
- image: opennms/build-env:11.0.14_9-3.8.4-b8249
6+
- image: opennms/build-env:17.0.6.0.10-3.8.8-b10459
77
environment:
88
MAVEN_OPTS: -Xmx2g
99

1010
build-debian-executor:
1111
docker:
12-
- image: cimg/openjdk:11.0.13
12+
- image: cimg/openjdk:17.0
1313
environment:
1414
MAVEN_OPTS: -Xmx2g
1515

@@ -19,7 +19,7 @@ executors:
1919
machine:
2020
image: ubuntu-2204:current
2121
environment:
22-
JAVA_HOME: /usr/lib/jvm/java-11-openjdk-amd64
22+
JAVA_HOME: /usr/lib/jvm/java-17-openjdk-amd64
2323
MAVEN_OPTS: -Xmx3200m
2424
TESTCONTAINERS_RYUK_DISABLED: true
2525
KEEP_TMP_OVERLAY: true
@@ -174,7 +174,7 @@ commands:
174174
- run:
175175
name: Run the tests
176176
command: |
177-
sudo apt update && sudo apt install -y openjdk-11-jdk
177+
sudo apt update && sudo apt install -y openjdk-17-jdk
178178
mkdir $TEST_RECORDING_DIR
179179
mvn install --projects org.opennms.alec:smoke-test --also-make -DskipTests=true
180180
cd smoke-test
@@ -241,13 +241,6 @@ jobs:
241241
- attach_workspace:
242242
at: ~/
243243

244-
- run:
245-
name: Update Repo list
246-
command: |
247-
sed -i s/mirror.centos.org/vault.centos.org/g /etc/yum.repos.d/CentOS-*.repo
248-
sed -i s/^#.*baseurl=http/baseurl=http/g /etc/yum.repos.d/CentOS-*.repo
249-
sed -i s/^mirrorlist=http/#mirrorlist=http/g /etc/yum.repos.d/CentOS-*.repo
250-
251244
- sign-packages/install-rpm-dependencies:
252245
skip_if_forked_pr: true
253246
- sign-packages/setup-env:
@@ -321,6 +314,11 @@ jobs:
321314
- attach_workspace:
322315
at: ~/
323316

317+
- run:
318+
name: Install build dependencies
319+
command: |
320+
sudo apt-get update && sudo apt-get install -y fakeroot dpkg-dev debhelper
321+
324322
- sign-packages/install-deb-dependencies:
325323
skip_if_forked_pr: true
326324
use_sudo: true

datasource/opennms-direct/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<Bundle-SymbolicName>${project.artifactId}</Bundle-SymbolicName>
2222
<Bundle-Version>${project.version}</Bundle-Version>
2323
<Import-Package>
24-
org.opennms.integration.api.v1.model,
24+
org.opennms.integration.api.*;version="${opennms.api.version.range}",
2525
org.opennms.alec.datasource.api,
2626
org.opennms.alec.datasource.common,
2727
org.opennms.alec.datasource.common.inventory,

datasource/opennms-kafka/src/test/java/org/opennms/alec/datasource/opennms/OpennmsDatasourceIT.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ public abstract class OpennmsDatasourceIT {
7171

7272
@Before
7373
public void setUp() throws IOException {
74+
System.setProperty("karaf.data", temporaryFolder.getRoot().getAbsolutePath());
75+
7476
// Create the producer
7577
Map<String, Object> senderProps = KafkaTestUtils.producerProps(embeddedKafkaRule.getEmbeddedKafka());
7678
senderProps.put("key.serializer", StringSerializer.class.getCanonicalName());

datasource/opennms-kafka/src/test/java/org/opennms/alec/datasource/opennms/OpennmsDatasourceStoreTest.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,7 @@ public void canBuildAndMaintainStores() throws IOException {
8888
datasource.setInventoryGcIntervalMs(step);
8989

9090
Topology topology = datasource.getKTopology();
91+
System.setProperty("karaf.data", temporaryFolder.getRoot().getAbsolutePath());
9192
Properties props = datasource.loadStreamsProperties();
9293
props.put(StreamsConfig.APPLICATION_ID_CONFIG, "test");
9394
props.put(StreamsConfig.BOOTSTRAP_SERVERS_CONFIG, "dummy:1234");

driver/main/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
<instructions>
2121
<Bundle-RequiredExecutionEnvironment>JavaSE-${java.version}</Bundle-RequiredExecutionEnvironment>
2222
<Import-Package>
23+
org.opennms.integration.api.*;version="${opennms.api.version.range}",
2324
com.google.common.*;version="${guava.major.version}",
2425
*
2526
</Import-Package>

features/ui/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
<Bundle-SymbolicName>${project.artifactId}</Bundle-SymbolicName>
2424
<Bundle-Version>${project.version}</Bundle-Version>
2525
<Import-Package>
26+
org.opennms.integration.api.*;version="${opennms.api.version.range}",
2627
com.google.common.*;version="${guava.major.version}",
2728
*
2829
</Import-Package>

karaf-features/src/main/resources/features.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
2-
<features name="alec-features" xmlns="http://karaf.apache.org/xmlns/features/v1.4.0">
2+
<features name="alec-features" xmlns="http://karaf.apache.org/xmlns/features/v1.3.0">
33

44
<!-- Datasources -->
55

pom.xml

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
<gson.version>2.8.2</gson.version>
6363
<hamcrest.version>1.3</hamcrest.version>
6464
<jakarta.version>2.3.3</jakarta.version>
65-
<java.version>11</java.version>
65+
<java.version>17</java.version>
6666
<jackson.version>2.12.3</jackson.version>
6767
<jaxrs.version>2.1.1</jaxrs.version>
6868
<jung.version>2.1.1</jung.version>
@@ -79,8 +79,9 @@
7979
<okhttp.version>3.10.0</okhttp.version>
8080
<okio.bundle.version>1.14.0_1</okio.bundle.version>
8181
<okhttp.bundle.version>3.10.0_2</okhttp.bundle.version>
82-
<opennms.api.version>1.0.0</opennms.api.version>
83-
<opennms.api.version.max>2.0.0</opennms.api.version.max><!-- exclusive ver. allowed for packages dependency rpm & deb-->
82+
<opennms.api.version>2.0.0</opennms.api.version>
83+
<opennms.api.version.max>3.0.0</opennms.api.version.max><!-- exclusive ver. allowed for packages dependency rpm & deb-->
84+
<opennms.api.version.range>[1.6,3.0)</opennms.api.version.range>
8485
<sink.protobuf.version>2.6.1</sink.protobuf.version>
8586
<osgi.version>6.0.0</osgi.version>
8687
<osgi.compendium.version>5.0.0</osgi.compendium.version>
@@ -423,6 +424,10 @@
423424
<configuration>
424425
<instructions>
425426
<Bundle-RequiredExecutionEnvironment>JavaSE-${java.version}</Bundle-RequiredExecutionEnvironment>
427+
<Import-Package>
428+
org.opennms.integration.api.*;version="${opennms.api.version.range}",
429+
*
430+
</Import-Package>
426431
</instructions>
427432
</configuration>
428433
</plugin>
@@ -530,8 +535,7 @@
530535
<artifactId>maven-surefire-plugin</artifactId>
531536
<version>2.22.1</version>
532537
<configuration>
533-
<!-- see: https://stackoverflow.com/questions/53010200/maven-surefire-could-not-find-forkedbooter-class -->
534-
<argLine>-Xmx1024m -Xms1024m -XX:MaxPermSize=512m -Djdk.net.URLClassPath.disableClassPathURLCheck=true</argLine>
538+
<argLine>-Xmx1024m -Xms1024m</argLine>
535539
</configuration>
536540
</plugin>
537541
<plugin>

processor/redundant/pom.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
<Export-Package>org.opennms.alec.processor.redundant</Export-Package>
2424
<Karaf-Commands>*</Karaf-Commands>
2525
<Import-Package>
26+
org.opennms.integration.api.*;version="${opennms.api.version.range}",
2627
com.google.common.*;version="${guava.major.version}",
2728
*
2829
</Import-Package>

smoke-test/src/main/java/org/opennms/alec/smoke/util/Karaf.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ public static void waitForBundleActive(String bundleName, InetSocketAddress serv
7777
.pollInterval(5, TimeUnit.SECONDS)
7878
.ignoreExceptions()
7979
.until(() -> {
80-
String[] output = runKarafCommands(serviceAddress, "bundle:list -s").split("\n");
80+
String[] output = runKarafCommands(serviceAddress, "bundle:list -s --no-format").split("\n");
8181
return Arrays.stream(output).anyMatch(row -> row.contains(bundleName) &&
8282
row.contains("Active"));
8383
});

0 commit comments

Comments
 (0)