Commit 3f55b24
committed
Address PR #152 review feedback
- SituationRestImpl.forwardSituation: wrap body in try/catch Exception
and return ALECRestUtils.somethingWentWrong(e) to preserve the
structured 5xx response that the previous forwardAndStoreSituation
helper provided.
- SituationDetailTab.vue: drop the dangling useUserStore() call left
over after the consent gate was removed (the import was already
deleted, the variable was unused).
Note: the shipped Karaf UI bundle under
features/ui/src/main/resources/ui-ext/ still contains the removed
welcome/configuration flow and needs a rebuild. That rebuild is
deferred to a follow-up - pre-existing case-sensitivity bugs in the
ui/ sources (axiosinstances.ts vs ./axiosInstances import,
TimeLine.vue vs Timeline import) prevent yarn build from succeeding
on a case-sensitive filesystem, and resolving those is out of scope
for this PR.
Assisted-by: Claude Code:Opus 4.71 parent a1658c9 commit 3f55b24
2 files changed
Lines changed: 7 additions & 5 deletions
File tree
- features/ui/src/main/java/org/opennms/alec/rest
- ui/src/components
Lines changed: 7 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
248 | 248 | | |
249 | 249 | | |
250 | 250 | | |
251 | | - | |
252 | | - | |
253 | | - | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
254 | 258 | | |
255 | 259 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
27 | | - | |
28 | 26 | | |
29 | 27 | | |
30 | 28 | | |
| |||
0 commit comments