Skip to content

Commit f6d2d34

Browse files
authored
Merge pull request #676 from KimBioInfoStudio/fix/stale-overlap-merge-675
fix: recompute overlap after trimming for merge mode
2 parents 794c0c5 + 9d8e888 commit f6d2d34

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

src/peprocessor.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -513,10 +513,9 @@ bool PairEndProcessor::processPairEnd(ReadPack* leftPack, ReadPack* rightPack, T
513513
// merging mode
514514
bool mergeProcessed = false;
515515
if(mOptions->merge.enabled && r1 && r2) {
516-
if(!ovComputed) {
517-
ov = OverlapAnalysis::analyze(r1, r2, mOptions->overlapDiffLimit, mOptions->overlapRequire, mOptions->overlapDiffPercentLimit/100.0);
518-
ovComputed = true;
519-
}
516+
// Always recompute overlap on post-trim reads for merge (fixes #675)
517+
ov = OverlapAnalysis::analyze(r1, r2, mOptions->overlapDiffLimit, mOptions->overlapRequire, mOptions->overlapDiffPercentLimit/100.0);
518+
ovComputed = true;
520519
if(ov.overlapped) {
521520
merged = OverlapAnalysis::merge(r1, r2, ov);
522521
int result = mFilter->passFilter(merged);

0 commit comments

Comments
 (0)