Skip to content

Commit 4483f0c

Browse files
committed
chore: add review suggestions
1 parent 437a586 commit 4483f0c

5 files changed

Lines changed: 26 additions & 19 deletions

File tree

src/components/About/About.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ export const AboutSection = ({ header }: { header: { fields: any } }) => {
99
<ContentWrapper>
1010
<Title>{title}</Title>
1111
<Subtitle>{subtitle}</Subtitle>
12-
<LinkButton href="/" text="Saiba mais" />
12+
<LinkButton href="/">Saiba mais</LinkButton>
1313
</ContentWrapper>
1414
</Wrapper>
1515
);
Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
import { Button } from "@/components/ui/button";
22
import Link from "next/link";
3-
import { Icon } from "../Icon/Icon";
3+
import { ReactNode } from "react";
44

55
export const LinkButton = ({
66
href,
7-
text,
7+
children,
88
variant = "primary",
99
className = "",
1010
}: {
1111
href: string;
12-
text: string;
12+
children: ReactNode;
1313
variant?: "primary" | "secondary";
1414
className?: string;
1515
}) => {
@@ -19,15 +19,7 @@ export const LinkButton = ({
1919
variant={variant}
2020
className={`w-full md:w-auto ${className}`}
2121
>
22-
<Link href={href}>
23-
{text}
24-
{variant === "secondary" && (
25-
<Icon
26-
id="expand"
27-
className="transform -rotate-90 !w-[8px] !h-[8px]"
28-
/>
29-
)}
30-
</Link>
22+
<Link href={href}>{children}</Link>
3123
</Button>
3224
);
3325
};

src/components/ProjectCard/ProjectCard.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,9 @@ const ProjectCard = ({ project }: { project: { fields: Project } }) => {
3131
<Title>{name}</Title>
3232
<Description>{description}</Description>
3333
</TextWrapper>
34-
<LinkButton href={link} text="Acessar" className="md:w-full" />
34+
<LinkButton href={link} className="md:w-full">
35+
Acessar
36+
</LinkButton>
3537
</InfoWrapper>
3638
</Wrapper>
3739
);

src/components/RecentSection/RecentSection.tsx

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import {
1212
import { Header } from "./RecentSection.styles";
1313
import ContentPost from "../ContentPost/ContentPost";
1414
import { LinkButton } from "../LinkButton/LinkButton";
15+
import { Icon } from "../Icon/Icon";
1516

1617
export const RecentSection = ({
1718
header,
@@ -51,7 +52,13 @@ export const RecentSection = ({
5152
{title} <RightIcon id="expand" size={14} />
5253
</Title>
5354
<div className="hidden md:block">
54-
<LinkButton href="/posts" text="Ver Todos" variant="secondary" />
55+
<LinkButton href="/posts" variant="secondary">
56+
Ver Todos
57+
<Icon
58+
id="expand"
59+
className="transform -rotate-90 !w-[8px] !h-[8px]"
60+
/>
61+
</LinkButton>
5562
</div>
5663
</Header>
5764
<Subtitle>{subtitle}</Subtitle>
@@ -71,7 +78,13 @@ export const RecentSection = ({
7178
))}
7279
</Carousel>
7380
<div className="block md:hidden mt-6 flex justify-center w-full">
74-
<LinkButton href="/posts" text="Ver Todos" variant="secondary" />
81+
<LinkButton href="/posts" variant="secondary">
82+
Ver Todos
83+
<Icon
84+
id="expand"
85+
className="transform -rotate-90 !w-[8px] !h-[8px]"
86+
/>
87+
</LinkButton>
7588
</div>
7689
</ContentWrapper>
7790
</Wrapper>

src/components/ui/button.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,19 @@ const buttonVariants = cva(
1010
variants: {
1111
variant: {
1212
primary:
13-
"bg-[var(--color-green-800)] text-white hover:bg-[var(--color-green-900)] rounded-md py-2 px-4 gap-[10px] min-w-[105px] min-h-[40px] font-sans text-sm leading-6",
13+
"bg-green-800 text-white hover:bg-green-900 min-w-[105px] font-sans text-sm leading-6",
1414
destructive:
1515
"bg-destructive text-white shadow-xs hover:bg-destructive/90 focus-visible:ring-destructive/20 dark:focus-visible:ring-destructive/40 dark:bg-destructive/60",
1616
outline:
1717
"border bg-background shadow-xs hover:bg-accent hover:text-accent-foreground dark:bg-input/30 dark:border-input dark:hover:bg-input/50",
1818
secondary:
19-
"bg-white text-[var(--color-green-900)] border border-[var(--color-grey-200)] hover:bg-[var(--color-grey-100)] rounded-md py-2 px-4 gap-[10px] w-[126px] min-h-[40px] font-sans text-sm leading-6",
19+
"bg-white text-green-900 border border-grey-200 hover:bg-grey-100 w-[126px] font-sans text-sm leading-6",
2020
ghost:
2121
"hover:bg-accent hover:text-accent-foreground dark:hover:bg-accent/50",
2222
link: "text-primary underline-offset-4 hover:underline",
2323
},
2424
size: {
25-
default: "h-9 px-4 py-2 has-[>svg]:px-3",
25+
default: "h-10 rounded-md px-4 py-2 gap-[10px] has-[>svg]:px-3",
2626
sm: "h-8 rounded-md gap-1.5 px-3 has-[>svg]:px-2.5",
2727
lg: "h-10 rounded-md px-6 has-[>svg]:px-4",
2828
icon: "size-9",

0 commit comments

Comments
 (0)