Skip to content

home-assistant.tests.components.conversation: re-enable test_error_no_device_on_floor#507016

Open
JamieMagee wants to merge 1 commit intoNixOS:masterfrom
JamieMagee:home-assistant-conversation
Open

home-assistant.tests.components.conversation: re-enable test_error_no_device_on_floor#507016
JamieMagee wants to merge 1 commit intoNixOS:masterfrom
JamieMagee:home-assistant-conversation

Conversation

@JamieMagee
Copy link
Copy Markdown
Member

The test_error_no_device_on_floor test was disabled due to an intent fixture mismatch introduced by a bad intents bump (home-assistant/core#162205), which was reverted in home-assistant/core#162226 and properly re-landed in home-assistant/core#162959 with intents 2026.2.13. Our intents package is at 2026.3.24, so the test passes now.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

…_device_on_floor

Fixed upstream by intents bump to 2026.2.13 in home-assistant/core#162959.
@nixpkgs-ci nixpkgs-ci Bot requested review from dotlambda, fabaff and mweinelt April 5, 2026 18:28
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 5, 2026
@JamieMagee
Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 507016
Commit: 96256d4b9d569b22cae21c3eb329568d5eda3d40 (subsequent changes)
Merge: 285b33557e62126cb83566d932fe61fe0109fc44

Logs: https://github.com/JamieMagee/nixpkgs-review-gha/actions/runs/24007635836


x86_64-linux

✅ 1 package built:
  • tests.home-assistant-component-tests.conversation

aarch64-linux

❌ 1 package failed to build:
  • tests.home-assistant-component-tests.conversation

Error logs: `aarch64-linux`
tests.home-assistant-component-tests.conversation
2026-04-05 18:28:12.195 INFO     SyncWorker_0 homeassistant.loader:loader.py:784 Loaded http from homeassistant.components.http
2026-04-05 18:28:12.196 INFO     MainThread homeassistant.setup:setup.py:393 Setting up http
2026-04-05 18:28:12.196 WARNING  MainThread aiohttp_fast_zlib:__init__.py:55 zlib_ng and isal are not available, falling back to zlib, performance will be degraded.
2026-04-05 18:28:12.206 INFO     MainThread homeassistant.setup:setup.py:393 Setting up intent
2026-04-05 18:28:12.207 INFO     MainThread homeassistant.setup:setup.py:393 Setting up conversation
=============================== warnings summary ===============================
homeassistant/runner.py:176
  /build/source/homeassistant/runner.py:176: DeprecationWarning: 'asyncio.DefaultEventLoopPolicy' is deprecated and slated for removal in Python 3.16
    class HassEventLoopPolicy(asyncio.DefaultEventLoopPolicy):  # type: ignore[name-defined,misc]

tests/conftest.py:154
/build/source/tests/conftest.py:154: DeprecationWarning: 'asyncio.set_event_loop_policy' is deprecated and slated for removal in Python 3.16
asyncio.set_event_loop_policy(runner.HassEventLoopPolicy(False))

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
--------------------------- snapshot report summary ----------------------------
69 snapshots passed.
=========================== short test summary info ============================
FAILED tests/components/conversation/test_default_agent.py::test_error_no_device_on_floor - AssertionError: assert 'Sorry, I am ... ground floor' == 'Sorry, I am ... g...
================== 1 failed, 213 passed, 2 warnings in 51.67s ==================

@SuperSandro2000
Copy link
Copy Markdown
Member

It fails on aarch64 though... Maybe make it conditional?

@SuperSandroBot
Copy link
Copy Markdown

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 507016
Commit: 96256d4b9d569b22cae21c3eb329568d5eda3d40 (subsequent changes)
Merge: 76ad206fe6dba122d2b2017a3b396e3c3025fa71

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/25507332646


x86_64-linux

⏩ 1 package marked as broken and skipped:
  • tests.home-assistant-component-tests.conversation

aarch64-linux

⏩ 1 package marked as broken and skipped:
  • tests.home-assistant-component-tests.conversation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

Status: Incoming

Development

Successfully merging this pull request may close these issues.

3 participants