verbose mode is completely wrong

[jperkin]

The -V flag is supposed to enable verbose mode during install and uninstall.

However, due to the way the verbosity flag is checked, it actually does the complete opposite. While it turns on the -v flag to pkg_add and pkg_delete, the output for those programs is now no longer written to the pkg_install-err.log file, and the file is no longer checked for warnings/errors.

Fixing this will change the default output, so needs to be considered how that may affect end users.

[Shruthii7]

@jperkin I would like to investigate the current implementation of -V to verify whether the described behavior still exists in current master. I will analyze how verbose mode interacts with pkg_install-err.log and report findings.

[Shruthii7]

@jperkin
I’ve completed an initial investigation of the current master implementation.
When verbosity is enabled:

1. open_pi_log() does not open pkg_install-err.log
2. dup2() is not called, so stderr is not redirected
3. close_pi_log() does not call analyse_pkglog()
4. log output is printed via printf(), but not written to err_fp

This appears to confirm that enabling -V disables pkg_install log tracking and warning/error analysis, which matches the issue description.
Before preparing a patch, I would like to confirm the intended behaviour of -V.