Skip to content

Commit ec11314

Browse files
mitchutemitchute
authored
Merge pull request #11492 from NatLabRockies/11477-water-coil-sizing-strings
Apply human readable text to autosizing strings
2 parents 35b4876 + 2251a01 commit ec11314

45 files changed

Lines changed: 116 additions & 319 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎src/EnergyPlus/Autosizing/All_Simple_Sizing.cc‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ Real64 DesiccantDehumidifierBFPerfDataFaceVelocitySizer::size(EnergyPlusData &st
283283
this->autoSizedValue = min(6.0, this->autoSizedValue);
284284
}
285285
if (this->isEpJSON) {
286-
this->sizingString = "nominal_air_face_velocity [m/s]";
286+
this->sizingString = "Nominal Air Face Velocity [m/s]";
287287
}
288288
this->selectSizerOutput(state, errorsFound);
289289
return this->autoSizedValue;

‎src/EnergyPlus/Autosizing/Base.cc‎

Lines changed: 23 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -652,7 +652,29 @@ bool BaseSizer::checkInitialized(EnergyPlusData &state, bool &errorsFound)
652652

653653
void BaseSizer::overrideSizingString(std::string_view const string)
654654
{
655-
this->sizingString = string;
655+
// some strings are set inside loops where field names are read in and change slightly.
656+
// (e.g., at Speed 1, at Speed 2, or high_speed vs low_speed)
657+
// these cannot easily be set in a component model's sizing function
658+
// for those corner cases convert snake_case to Camel Case here:
659+
std::string word, result;
660+
std::string str{string.data(), string.size()}; // convert string_view to string
661+
std::istringstream iss(str);
662+
// blank strings will jump to end, Camel Case strings will pass through loop once
663+
while (std::getline(iss, word, '_')) {
664+
if (word == "for" || word == "per" || word == "at") { // don't Capitalize certain words
665+
result += word;
666+
} else if (word == "ua") { // Capitalize all letters of certain words
667+
std::transform(word.begin(), word.end(), word.begin(), ::toupper);
668+
result += word;
669+
} else {
670+
result += toupper(word[0]); // Capitalize the first letter
671+
result += word.substr(1); // Append the rest of the word
672+
}
673+
if (result.size() != str.size()) {
674+
result.insert(result.size(), " "); // insert space between words but not at end of string
675+
}
676+
}
677+
this->sizingString = result;
656678
this->overrideSizeString = false;
657679
}
658680

‎src/EnergyPlus/Autosizing/CoolingAirFlowSizing.cc‎

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -336,25 +336,14 @@ Real64 CoolingAirFlowSizer::size(EnergyPlusData &state, Real64 _originalValue, b
336336
if (this->overrideSizeString) {
337337
if (Util::SameString(this->compType, "ZoneHVAC:FourPipeFanCoil")) {
338338
this->sizingString = "Maximum Supply Air Flow Rate [m3/s]";
339-
if (this->isEpJSON) {
340-
this->sizingString = "maximum_supply_air_flow_rate [m3/s]";
341-
}
342339
} else if (this->coilType == HVAC::CoilType::CoolingDXTwoSpeed) {
343340
if (this->dataDXSpeedNum == 1) { // mode 1 is high speed in DXCoils loop
344-
if (this->isEpJSON) {
345-
this->sizingString = "high_speed_rated_air_flow_rate [m3/s]";
346-
} else {
347-
this->sizingString = "High Speed Rated Air Flow Rate [m3/s]";
348-
}
341+
this->sizingString = "High Speed Rated Air Flow Rate [m3/s]";
349342
} else if (this->dataDXSpeedNum == 2) {
350-
if (this->isEpJSON) {
351-
this->sizingString = "low_speed_rated_air_flow_rate [m3/s]";
352-
} else {
353-
this->sizingString = "Low Speed Rated Air Flow Rate [m3/s]";
354-
}
343+
this->sizingString = "Low Speed Rated Air Flow Rate [m3/s]";
355344
}
356345
} else if (this->isEpJSON) {
357-
this->sizingString = "cooling_supply_air_flow_rate [m3/s]";
346+
this->sizingString = "Cooling Supply Air Flow Rate [m3/s]";
358347
}
359348
}
360349
if (this->dataScalableSizingON) {

‎src/EnergyPlus/Autosizing/CoolingCapacitySizing.cc‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -550,9 +550,7 @@ Real64 CoolingCapacitySizer::size(EnergyPlusData &state, Real64 _originalValue,
550550

551551
// override sizing string
552552
if (this->overrideSizeString) {
553-
if (this->isEpJSON) {
554-
this->sizingString = "cooling_design_capacity [W]";
555-
}
553+
this->sizingString = "Cooling Design Capacity [W]";
556554
}
557555
if (this->dataScalableCapSizingON) {
558556
int const SELECT_CASE_var(this->zoneEqSizing(this->curZoneEqNum).SizingMethod(HVAC::CoolingCapacitySizing));

‎src/EnergyPlus/Autosizing/CoolingSHRSizing.cc‎

Lines changed: 6 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -137,40 +137,18 @@ void CoolingSHRSizer::updateSizingString(EnergyPlusData &state)
137137
// override sizingString to match existing text
138138
if (this->coilType == HVAC::CoilType::CoolingDXTwoSpeed) {
139139
if (this->dataDXSpeedNum == 1) { // mode 1 is high speed in DXCoils loop
140-
if (this->isEpJSON) {
141-
this->sizingString = "high_speed_rated_sensible_heat_ratio";
142-
} else {
143-
this->sizingString = "High Speed Rated Sensible Heat Ratio";
144-
}
140+
this->sizingString = "High Speed Rated Sensible Heat Ratio";
145141
} else if (this->dataDXSpeedNum == 2) {
146-
if (this->isEpJSON) {
147-
this->sizingString = "low_speed_gross_rated_sensible_heat_ratio";
148-
} else {
149-
this->sizingString = "Low Speed Gross Rated Sensible Heat Ratio";
150-
}
142+
this->sizingString = "Low Speed Gross Rated Sensible Heat Ratio";
151143
}
152144
} else if (this->coilType == HVAC::CoilType::CoolingDXMultiSpeed) {
153-
if (this->isEpJSON) {
154-
this->sizingString = fmt::format("speed_{}_rated_sensible_heat_ratio", state.dataSize->DataDXSpeedNum);
155-
} else {
156-
this->sizingString = fmt::format("Speed {} Rated Sensible Heat Ratio", state.dataSize->DataDXSpeedNum);
157-
}
145+
this->sizingString = fmt::format("Speed {} Rated Sensible Heat Ratio", state.dataSize->DataDXSpeedNum);
158146
} else if (this->coilType == HVAC::CoilType::CoolingVRFFluidTCtrl) {
159-
if (this->isEpJSON) {
160-
this->sizingString = "rated_sensible_heat_ratio";
161-
} else {
162-
this->sizingString = "Rated Sensible Heat Ratio";
163-
}
147+
this->sizingString = "Rated Sensible Heat Ratio";
164148
} else if (this->coilType == HVAC::CoilType::CoolingDXCurveFit) {
165-
if (this->isEpJSON) {
166-
this->sizingString = "gross_sensible_heat_ratio";
167-
} else {
168-
this->sizingString = "Gross Sensible Heat Ratio";
169-
}
149+
this->sizingString = "Gross Sensible Heat Ratio";
170150
} else {
171-
if (this->isEpJSON) {
172-
this->sizingString = "gross_rated_sensible_heat_ratio";
173-
}
151+
this->sizingString = "Gross Rated Sensible Heat Ratio";
174152
}
175153
}
176154

‎src/EnergyPlus/Autosizing/CoolingWaterDesAirInletHumRatSizing.cc‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -101,9 +101,7 @@ Real64 CoolingWaterDesAirInletHumRatSizer::size(EnergyPlusData &state, Real64 _o
101101
}
102102
}
103103
if (this->overrideSizeString) {
104-
if (this->isEpJSON) {
105-
this->sizingString = "design_inlet_air_humidity_ratio [kgWater/kgDryAir]";
106-
}
104+
this->sizingString = "Design Inlet Air Humidity Ratio [kgWater/kgDryAir]";
107105
}
108106
this->selectSizerOutput(state, errorsFound);
109107
if (this->isCoilReportObject) {

‎src/EnergyPlus/Autosizing/CoolingWaterDesAirInletTempSizing.cc‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,9 +125,7 @@ Real64 CoolingWaterDesAirInletTempSizer::size(EnergyPlusData &state, Real64 _ori
125125
}
126126
// override sizing string
127127
if (this->overrideSizeString) {
128-
if (this->isEpJSON) {
129-
this->sizingString = "design_inlet_air_temperature [C]";
130-
}
128+
this->sizingString = "Design Inlet Air Temperature [C]";
131129
}
132130
this->selectSizerOutput(state, errorsFound);
133131
if (this->isCoilReportObject) {

‎src/EnergyPlus/Autosizing/CoolingWaterDesAirOutletHumRatSizing.cc‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -155,9 +155,7 @@ Real64 CoolingWaterDesAirOutletHumRatSizer::size(EnergyPlusData &state, Real64 _
155155
}
156156
}
157157
if (this->overrideSizeString) {
158-
if (this->isEpJSON) {
159-
this->sizingString = "design_outlet_air_humidity_ratio [kgWater/kgDryAir]";
160-
}
158+
this->sizingString = "Design Outlet Air Humidity Ratio [kgWater/kgDryAir]";
161159
}
162160
this->selectSizerOutput(state, errorsFound);
163161
if (this->isCoilReportObject) {

‎src/EnergyPlus/Autosizing/CoolingWaterDesAirOutletTempSizing.cc‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -169,9 +169,7 @@ Real64 CoolingWaterDesAirOutletTempSizer::size(EnergyPlusData &state, Real64 _or
169169
}
170170
// override sizing string
171171
if (this->overrideSizeString) {
172-
if (this->isEpJSON) {
173-
this->sizingString = "design_outlet_air_temperature [C]";
174-
}
172+
this->sizingString = "Design Outlet Air Temperature [C]";
175173
}
176174
this->selectSizerOutput(state, errorsFound);
177175
if (this->isCoilReportObject) {

‎src/EnergyPlus/Autosizing/CoolingWaterDesWaterInletTempSizing.cc‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,9 +66,7 @@ Real64 CoolingWaterDesWaterInletTempSizer::size(EnergyPlusData &state, Real64 _o
6666
this->errorType = AutoSizingResultType::ErrorType1;
6767
}
6868
if (this->overrideSizeString) {
69-
if (this->isEpJSON) {
70-
this->sizingString = "design_inlet_water_temperature [C]";
71-
}
69+
this->sizingString = "Design Inlet Water Temperature [C]";
7270
}
7371
this->selectSizerOutput(state, errorsFound);
7472
if (this->isCoilReportObject) {

0 commit comments

Comments
 (0)