Syntax error in asserts

[patmjen]

Hello,

When compiling kaolin I got errors due to L166 and L363 in /kaolin/csrc/ops/spc/convolution.cpp.

kaolin/kaolin/csrc/ops/spc/convolution.cpp

Lines 163 to 166 in b47f216

	int Qlevel = level;
	int Plevel = Qlevel - jump;
	int Olevel = pyramid.size(2)-2;
	assert(PLevel >= 0);

kaolin/kaolin/csrc/ops/spc/convolution.cpp

Lines 360 to 363 in b47f216

	int Qlevel = level;
	int Plevel = Qlevel + jump;
	int Olevel = pyramid.size(2)-2;
	assert(PLevel <= Olevel);

Both lines have an assert that references PLevel which is not defined. I assume it should be Plevel? Changing the lines to that fixed the issue for me at least.

Thanks for a great library!

[Caenorst]

@patmjen , thank you for your interest in Kaolin. Good catch, it looks like our CI / workstation skipped this issue.

We should fix that, out of curiosity what is your system config?

[patmjen]

Great, thank you! Here's my system info, as reported by PyTorch's collect_env.py:

$ python collect_env.py
Collecting environment information...
PyTorch version: 1.12.1+cu116
Is debug build: False
CUDA used to build PyTorch: 11.6
ROCM used to build PyTorch: N/A

OS: Scientific Linux release 7.9 (Nitrogen) (x86_64)
GCC version: (GCC) 10.3.0
Clang version: Could not collect
CMake version: version 2.8.12.2
Libc version: glibc-2.17

Python version: 3.9.14 (main, Sep 16 2022, 10:48:44)  [GCC 10.3.0] (64-bit runtime)
Python platform: Linux-3.10.0-1160.76.1.el7.x86_64-x86_64-with-glibc2.17
Is CUDA available: True
CUDA runtime version: 11.6.55
CUDA_MODULE_LOADING set to:
GPU models and configuration:
GPU 0: NVIDIA A100-PCIE-40GB
GPU 1: NVIDIA A100-PCIE-40GB

Nvidia driver version: 515.65.01
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

Versions of relevant libraries:
[pip3] numpy==1.23.3
[pip3] torch==1.12.1+cu116
[pip3] torchvision==0.13.1+cu116
[conda] No relevant packages

Let me know if you need anything else.

[dis-xcom]

I faced the same issue during building the project with "python setup.py develop" , but without conda:

FAILED: /home/dis/develop-ai/kaolin/build/temp.linux-x86_64-3.8/kaolin/csrc/ops/spc/convolution.o 
c++ -MMD -MF /home/dis/develop-ai/kaolin/build/temp.linux-x86_64-3.8/kaolin/csrc/ops/spc/convolution.o.d -fPIC -DWITH_CUDA -DTHRUST_IGNORE_CUB_VERSION_CHECK -I/home/dis/venvpython3.8/lib/python3.8/site-packages/torch/include -I/home/dis/venvpython3.8/lib/python3.8/site-packages/torch/include/torch/csrc/api/include -I/home/dis/venvpython3.8/lib/python3.8/site-packages/torch/include/TH -I/home/dis/venvpython3.8/lib/python3.8/site-packages/torch/include/THC -I/opt/cuda/include -I/home/dis/venvpython3.8/include -I/usr/include/python3.8 -c -c /home/dis/develop-ai/kaolin/kaolin/csrc/ops/spc/convolution.cpp -o /home/dis/develop-ai/kaolin/build/temp.linux-x86_64-3.8/kaolin/csrc/ops/spc/convolution.o -O3 -DTORCH_API_INCLUDE_EXTENSION_H '-DPYBIND11_COMPILER_TYPE="_gcc"' '-DPYBIND11_STDLIB="_libstdcpp"' '-DPYBIND11_BUILD_ABI="_cxxabi1011"' -DTORCH_EXTENSION_NAME=_C -D_GLIBCXX_USE_CXX11_ABI=0 -std=c++17
In file included from /usr/lib/gcc/x86_64-pc-linux-gnu/13/include/g++-v13/cassert:44,
                 from /home/dis/venvpython3.8/lib/python3.8/site-packages/torch/include/c10/util/SmallVector.h:28,
                 from /home/dis/venvpython3.8/lib/python3.8/site-packages/torch/include/c10/util/ArrayRef.h:21,
                 from /home/dis/venvpython3.8/lib/python3.8/site-packages/torch/include/c10/core/MemoryFormat.h:3,
                 from /home/dis/venvpython3.8/lib/python3.8/site-packages/torch/include/ATen/core/TensorBody.h:13,
                 from /home/dis/venvpython3.8/lib/python3.8/site-packages/torch/include/ATen/core/Tensor.h:3,
                 from /home/dis/venvpython3.8/lib/python3.8/site-packages/torch/include/ATen/native/TypeProperties.h:3,
                 from /home/dis/develop-ai/kaolin/kaolin/csrc/ops/spc/../../check.h:19,
                 from /home/dis/develop-ai/kaolin/kaolin/csrc/ops/spc/convolution.cpp:17:
/home/dis/develop-ai/kaolin/kaolin/csrc/ops/spc/convolution.cpp: In function ‘std::tuple<at::Tensor, int> kaolin::Conv3d_forward(at::Tensor, at::Tensor, uint32_t, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, uint32_t)’:
/home/dis/develop-ai/kaolin/kaolin/csrc/ops/spc/convolution.cpp:166:10: error: ‘PLevel’ was not declared in this scope; did you mean ‘Plevel’?
  166 |   assert(PLevel >= 0);
      |          ^~~~~~
/home/dis/develop-ai/kaolin/kaolin/csrc/ops/spc/convolution.cpp: In function ‘std::tuple<at::Tensor, int> kaolin::ConvTranspose3d_forward(at::Tensor, at::Tensor, uint32_t, at::Tensor, at::Tensor, at::Tensor, at::Tensor, at::Tensor, uint32_t)’:
/home/dis/develop-ai/kaolin/kaolin/csrc/ops/spc/convolution.cpp:363:10: error: ‘PLevel’ was not declared in this scope; did you mean ‘Plevel’?
  363 |   assert(PLevel <= Olevel);
      |          ^~~~~~

Build environment details:

$ python collect_env.py
Collecting environment information...
PyTorch version: 2.4.1+cu121
Is debug build: False
CUDA used to build PyTorch: 12.1
ROCM used to build PyTorch: N/A

OS: Gentoo Linux (x86_64)
GCC version: (Gentoo 13.3.1_p20241220 p2) 13.3.1 20241220
Clang version: 19.1.7
CMake version: version 3.31.5
Libc version: glibc-2.41

Python version: 3.8.20 (default, Dec 13 2024, 04:51:00)  [GCC 13.3.1 20240614] (64-bit runtime)
Python platform: Linux-6.13.2-gentoo-dist-x86_64-12th_Gen_Intel-R-_Core-TM-_i5-12600-with-glibc2.34
Is CUDA available: True
CUDA runtime version: 12.6.68
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration: GPU 0: NVIDIA GeForce RTX 4070 Ti SUPER
Nvidia driver version: 570.86.16
cuDNN version: Could not collect
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True

CPU:
Architecture:                         x86_64
CPU op-mode(s):                       32-bit, 64-bit
Address sizes:                        46 bits physical, 48 bits virtual
Byte Order:                           Little Endian
CPU(s):                               12
On-line CPU(s) list:                  0-11
Vendor ID:                            GenuineIntel
Model name:                           12th Gen Intel(R) Core(TM) i5-12600
CPU family:                           6
Model:                                151
Thread(s) per core:                   2
Core(s) per socket:                   6
Socket(s):                            1
Stepping:                             5
CPU(s) scaling MHz:                   92%
CPU max MHz:                          4800.0000
CPU min MHz:                          800.0000
BogoMIPS:                             6607.00
Flags:                                fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf tsc_known_freq pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault ssbd ibrs ibpb stibp ibrs_enhanced tpr_shadow flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb intel_pt sha_ni xsaveopt xsavec xgetbv1 xsaves split_lock_detect user_shstk avx_vnni dtherm ida arat pln pts hwp hwp_notify hwp_act_window hwp_epp hwp_pkg_req hfi vnmi umip pku ospke waitpkg gfni vaes vpclmulqdq rdpid movdiri movdir64b fsrm md_clear serialize pconfig arch_lbr ibt flush_l1d arch_capabilities
Virtualization:                       VT-x
L1d cache:                            288 KiB (6 instances)
L1i cache:                            192 KiB (6 instances)
L2 cache:                             7.5 MiB (6 instances)
L3 cache:                             18 MiB (1 instance)
NUMA node(s):                         1
NUMA node0 CPU(s):                    0-11
Vulnerability Gather data sampling:   Not affected
Vulnerability Itlb multihit:          Not affected
Vulnerability L1tf:                   Not affected
Vulnerability Mds:                    Not affected
Vulnerability Meltdown:               Not affected
Vulnerability Mmio stale data:        Not affected
Vulnerability Reg file data sampling: Vulnerable: No microcode
Vulnerability Retbleed:               Not affected
Vulnerability Spec rstack overflow:   Not affected
Vulnerability Spec store bypass:      Mitigation; Speculative Store Bypass disabled via prctl
Vulnerability Spectre v1:             Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2:             Mitigation; Enhanced / Automatic IBRS; IBPB conditional; RSB filling; PBRSB-eIBRS SW sequence; BHI BHI_DIS_S
Vulnerability Srbds:                  Not affected
Vulnerability Tsx async abort:        Not affected

Versions of relevant libraries:
[pip3] flake8==4.0.1
[pip3] flake8-unused-arguments==0.0.10
[pip3] mypy-extensions==1.0.0
[pip3] numpy==1.22.0
[pip3] nvidia-cublas-cu12==12.1.3.1
[pip3] nvidia-cuda-cupti-cu12==12.1.105
[pip3] nvidia-cuda-nvrtc-cu12==12.1.105
[pip3] nvidia-cuda-runtime-cu12==12.1.105
[pip3] nvidia-cudnn-cu12==9.1.0.70
[pip3] nvidia-cufft-cu12==11.0.2.54
[pip3] nvidia-curand-cu12==10.3.2.106
[pip3] nvidia-cusolver-cu12==11.4.5.107
[pip3] nvidia-cusparse-cu12==12.1.0.106
[pip3] nvidia-nccl-cu12==2.20.5
[pip3] nvidia-nvjitlink-cu12==12.3.101
[pip3] nvidia-nvtx-cu12==12.1.105
[pip3] onnxruntime==1.19.2
[pip3] torch==2.4.1
[pip3] torchaudio==2.4.1
[pip3] torchvision==0.19.1
[pip3] triton==3.0.0
[conda] Could not collect

[github-actions]

Stale issue, please reopen if still relevant