Checked for duplicates
No - I haven't checked
π§βπ¬ User Persona(s)
PDS Engineer
πͺ Motivation
so that our branch integration workflow accurately reflects test building against the same version we have developed against.
π Additional Details
In a recent PR I added a comment about warnings being emitted when I ran a test build locally. This got me wondering about our branch-cicd workflow and why it hadn't reported an issue which is when I found that our workflow always targets the latest release of Node.js.
This will help: https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#node-version-file
Node version file
The node-version-file input accepts a path to a file containing the version of Node.js to be used by a project, for example .nvmrc, .node-version, .tool-versions, or package.json. If both the node-version and the node-version-file inputs are provided then the node-version input is used. See supported version syntax.
The action will search for the node version file relative to the repository root.
steps:
- uses: actions/checkout@v6
- uses: actions/setup-node@v6
with:
node-version-file: '.nvmrc'
- run: npm ci
- run: npm test
Acceptance Criteria
Given our .nvmrc is populated with a valid version of Node.js
When I open a PR
Then I expect the branch integration test to use that version of Node.js when conducting the test build.
βοΈ Engineering Details
No response
π I&T
No response
Checked for duplicates
No - I haven't checked
π§βπ¬ User Persona(s)
PDS Engineer
πͺ Motivation
so that our branch integration workflow accurately reflects test building against the same version we have developed against.
π Additional Details
In a recent PR I added a comment about warnings being emitted when I ran a test build locally. This got me wondering about our branch-cicd workflow and why it hadn't reported an issue which is when I found that our workflow always targets the
latestrelease of Node.js.This will help: https://github.com/actions/setup-node/blob/main/docs/advanced-usage.md#node-version-file
Acceptance Criteria
Given our
.nvmrcis populated with a valid version of Node.jsWhen I open a PR
Then I expect the branch integration test to use that version of Node.js when conducting the test build.
βοΈ Engineering Details
No response
π I&T
No response