Skip to content

[BUG] JavaScript error occurs when backing out of screenshare UI #196

@homomorphist

Description

@homomorphist

Prerequisites

  • I have searched existing issues and found no duplicates
  • I have checked the FAQ/Wiki and found no solution

Description

Backing out of starting a screenshare will cause the main thread to throw an error and/or indefinitely wait for the UI to finish.

Uncaught Exception:
TypeError: Video was requested, but no video stream was provided
at BrowserWindow.<anonymous> (file:///app/bin/goofcord/resources/app.asar/ts-out/chunk-8f93f4ke.js:226:7371)
at Object.onceWrapper (node:events:623:26)
at BrowserWindow.emit (node:events:520:35)
at click (file:///app/bin/goofcord/resources/app.asar/ts-out/chunk-8f93f4ke.js:411:3246)

The final stacktrace line only appears via the KDE/Wayland method (see below), otherwise it is omitted.

Steps to Reproduce

There are two ways to reproduce this, one being closing the KDE/Wayland window, the other being closing the GoofCord window.

KDE/Wayland

  1. Join a voice call where you have the capability to screenshare.
  2. Click on the screenshare button.
  3. Close the new "Share screen with GoofCord" popup via window controls.
  4. Optionally, observe that you can no longer start a new stream.
  5. Refresh the GoofCord application with CTRL + SHIFT + R.
  6. Observe error notification, which combined with the inability to open a new stream implies to me it never received a rejection of the prompt.

GoofCord

  1. Join a voice call where you have the capability to screenshare.
  2. Click on the screenshare button.
  3. Click on "Laptop screen" in the "Share screen with GoofCord" popup.
  4. Close the new "GoofCord Screenshare" popup via window controls.
  5. Observe error notification.

Expected Behavior

The screenshare isn't started, and no error is reported. I can start a stream again if I so desire.

Actual Behavior

An error is reported, and the ability to start a stream is hindered (if you closed the KDE/Wayland one).

Screenshots

error; see prior code block

(See prior note regarding last line)

Operating System

Bazzite DX (NVIDIA) 43

GoofCord Version

2.2.0

Installation Method

Flathub

Additional Information

I don't know / can't recall if this issue was present before the new screenshare UI added this version. It's never worked entirely well for me, maybe still a few things to sort out on my side haha but I don't think this is one of them.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions