Skip to content

Commit 6339eb1

Browse files
committed
Remove misclassified modules from KnownThirdPartyRDMAModules
Mirror of the doca-driver-build fix. These modules were incorrectly classified as third-party RDMA modules in the init container's dependency checker: - iw_cm: Core RDMA infrastructure module managed by MOFED - ib_srp, ib_iser, ib_isert: Storage protocol modules handled by UNLOAD_STORAGE_MODULES - nvme_rdma, nvmet_rdma, rpcrdma, xprtrdma: Storage-over-RDMA modules already in the driver container's StorageModules list With these in the list, the init container would either silently skip them (when UNLOAD_THIRD_PARTY_RDMA_MODULES=true) instead of letting UNLOAD_STORAGE_MODULES handle them properly, or misclassify them in error output (when false). Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
1 parent 9542ce2 commit 6339eb1

1 file changed

Lines changed: 7 additions & 4 deletions

File tree

pkg/modules/checker.go

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,18 @@ const (
3232
)
3333

3434
// KnownThirdPartyRDMAModules is the set of non-NVIDIA kernel modules from the RDMA ecosystem
35-
// (rdma-core providers and consumers). When UnloadThirdPartyRDMA is true these are treated
36-
// as allowed and the driver container will handle their unloading.
35+
// (third-party NIC vendor RDMA providers). When UnloadThirdPartyRDMA is true these are
36+
// treated as allowed and the driver container will handle their unloading.
37+
//
38+
// NOTE: Do NOT add core RDMA infrastructure modules (iw_cm, ib_cm, rdma_cm, etc.)
39+
// here — MOFED manages those in its own unload sequence. Do NOT add storage-over-RDMA
40+
// modules (ib_srp, ib_iser, ib_isert, nvme_rdma, etc.) — those are handled by
41+
// UNLOAD_STORAGE_MODULES in the driver container.
3742
var KnownThirdPartyRDMAModules = map[string]struct{}{
3843
"bnxt_re": {}, "efa": {}, "erdma": {}, "iw_cxgb4": {},
3944
"hfi1": {}, "hns_roce": {}, "ionic_rdma": {}, "irdma": {},
4045
"ib_qib": {}, "mana_ib": {}, "ocrdma": {}, "qedr": {},
4146
"rdma_rxe": {}, "siw": {}, "vmw_pvrdma": {},
42-
"ib_srp": {}, "ib_iser": {}, "iw_cm": {}, "ib_isert": {},
43-
"nvme_rdma": {}, "nvmet_rdma": {}, "rpcrdma": {}, "xprtrdma": {},
4447
}
4548

4649
// DependencyReport contains the 3-tier classification of blocking dependencies.

0 commit comments

Comments
 (0)