testad

Author: asif17r

src/main/java/com/example/lostnfound/service/ImageService.java

@@ -27,6 +27,9 @@ public class ImageService {
     private final Path uploadPath;
     private final EmbeddingService embeddingService;
 
+    @Value("${app.baseUrl}")
+    private String baseUrl;
+
     public ImageService(ImageRepository imageRepository, @Value("${app.upload.dir}") String uploadDir, EmbeddingService embeddingService) {
         this.imageRepository = imageRepository;
         this.uploadPath = Path.of(uploadDir);
@@ -42,13 +45,15 @@ private void createUploadDirectory() {
         }
     }
 
-    @Value("${app.baseUrl}")
-    private String baseUrl;
     public String getImageUri(Long id) {
         return baseUrl + "/images/" + id;
     }
 
     public Image saveImage(MultipartFile file) throws IOException, InterruptedException {
+        if (file.isEmpty()) {
+            throw new IllegalArgumentException("File must not be empty");
+        }
+
         String originalName = Objects.requireNonNull(file.getOriginalFilename(), "File must have a name");
 
         String extension = "";
@@ -117,6 +122,13 @@ public List<Image> getAllImages() {
 	}
 
     float similarityScore(float[] embedding1, float[] embedding2) {
+        Objects.requireNonNull(embedding1, "First embedding must not be null");
+        Objects.requireNonNull(embedding2, "Second embedding must not be null");
+
+        if (embedding1.length != embedding2.length) {
+            throw new IllegalArgumentException("Embeddings must have the same length");
+        }
+
         float score = 0;
         for (int i = 0; i < embedding1.length; i++) {
             score += (float) Math.pow(embedding1[i] - embedding2[i], 2);

src/main/java/com/example/lostnfound/service/PostService.java

@@ -116,6 +116,9 @@ public List<Post> findTopKSimilarPosts(float[] embed, Long topK) {
 
     public List<Post> getCustomizedPosts() throws UserNotFoundException {
         User currentUser = userService.getCurrentUser();
+        if (currentUser.getEmbedding() == null) {
+            throw new IllegalStateException("User has no embedding data");
+        }
         return findTopKSimilarPosts(currentUser.getEmbedding(), Long.MAX_VALUE);
     }
 

src/test/java/com/example/lostnfound/service/ImageServiceTest.java

@@ -1,9 +1,7 @@
 package com.example.lostnfound.service;
 
 import com.example.lostnfound.exception.ImageNotFoundException;
-
 import com.example.lostnfound.exception.ImageStorageException;
-
 import com.example.lostnfound.model.Image;
 import com.example.lostnfound.repository.ImageRepository;
 import com.example.lostnfound.service.ai.embedding.EmbeddingService;
@@ -16,6 +14,7 @@
 import org.springframework.core.io.Resource;
 import org.springframework.core.io.UrlResource;
 import org.springframework.mock.web.MockMultipartFile;
+import org.springframework.test.util.ReflectionTestUtils;
 
 import java.io.IOException;
 import java.io.InputStream;
@@ -183,4 +182,43 @@ void testGetAllImages() {
         assertEquals(2, result.size());
         assertSame(images, result);
     }
+
+    @Test
+    void testSaveImage_EmptyFile() {
+        MockMultipartFile emptyFile = new MockMultipartFile("file", "", "image/jpeg", new byte[0]);
+        assertThrows(IllegalArgumentException.class, () -> imageService.saveImage(emptyFile));
+    }
+
+    @Test
+    void testSaveImage_NullFilename() {
+        MockMultipartFile nullNameFile = new MockMultipartFile("file", null, "image/jpeg", "test".getBytes());
+        assertThrows(IllegalArgumentException.class, () -> imageService.saveImage(nullNameFile));
+    }
+
+    @Test
+    void testGetImageUri() {
+        ReflectionTestUtils.setField(imageService, "baseUrl", "http://localhost:8080");
+        String uri = imageService.getImageUri(1L);
+        assertEquals("http://localhost:8080/images/1", uri);
+    }
+
+    @Test
+    void testSimilarityScore_ZeroDistance() {
+        float[] embedding1 = {1.0f, 2.0f, 3.0f};
+        float[] embedding2 = {1.0f, 2.0f, 3.0f};
+        assertEquals(0.0f, imageService.similarityScore(embedding1, embedding2), 0.0001f);
+    }
+
+    @Test
+    void testSimilarityScore_NullEmbeddings() {
+        assertThrows(NullPointerException.class, () -> imageService.similarityScore(null, new float[]{1.0f}));
+        assertThrows(NullPointerException.class, () -> imageService.similarityScore(new float[]{1.0f}, null));
+    }
+
+    @Test
+    void testSimilarityScore_DifferentLengths() {
+        float[] embedding1 = {1.0f, 2.0f};
+        float[] embedding2 = {1.0f, 2.0f, 3.0f};
+        assertThrows(IllegalArgumentException.class, () -> imageService.similarityScore(embedding1, embedding2));
+    }
 }

src/test/java/com/example/lostnfound/service/PostServiceTest.java

@@ -157,5 +157,47 @@ void testGetCustomizedPosts() throws UserNotFoundException {
         verify(postRepo).findTopKSimilarPosts(any(float[].class), eq(Long.MAX_VALUE));
     }
 
+    @Test
+    void testUpdatePost_PartialUpdate() throws PostNotFoundException {
+        Post existingPost = new Post();
+        existingPost.setId(1L);
+        existingPost.setTitle("Old Title");
+        existingPost.setDescription("Old Description");
+
+        Post updatedPost = new Post();
+        updatedPost.setTitle("New Title");
+        // description not set, should remain unchanged
+
+        when(postRepo.findById(1L)).thenReturn(Optional.of(existingPost));
+
+        postService.updatePost(1L, updatedPost);
+
+        assertEquals("New Title", existingPost.getTitle());
+        assertEquals("Old Description", existingPost.getDescription());
+    }
+
+    @Test
+    void testGetCustomizedPosts_UserWithoutEmbedding() throws UserNotFoundException {
+        User userWithoutEmbedding = new User();
+        userWithoutEmbedding.setUserId(2L);
+        userWithoutEmbedding.setEmbedding(null);
+
+        when(userService.getCurrentUser()).thenReturn(userWithoutEmbedding);
+        
+        assertThrows(IllegalStateException.class, () -> postService.getCustomizedPosts());
+    }
+
+    @Test
+    void testSearchPosts() {
+        String searchTerm = "lost phone";
+        List<Post> expectedPosts = List.of(post);
+        when(postRepo.searchPosts(searchTerm)).thenReturn(expectedPosts);
+
+        List<Post> results = postService.searchPosts(searchTerm);
+
+        assertEquals(expectedPosts, results);
+        verify(postRepo).searchPosts(searchTerm);
+    }
+
 }