deps: upgrade hickory to 0.25

There are a few breaking changes in the API that we need to tackle
here, but they're generally fine.

Since our libunbound crate uses hickory-proto, I had to upgrade
that dep over there and reference the updated git rev here in
this commit; we don't publish that to crates.io.

The main thing that stood out in the upgrade is that the zone
file parser used by the TestResolver now seems to create
records with varying FQDN-ness. This may just be that it is
now passing data through from the underlying zone data, but
it caused a number of the SPF and DKIM test cases to fail
without canonicalizing the names to FQDN.  I chose to do that
in the TestResolver rather than reviewing all the input zone
data, with the rationale being that it is least surprising
to have the test resolver fix that up than to puzzle over
records not resolving due to a missing trailing dot when
more tests are written in the future.

This commit doesn't try to take advantage of the improvements
to DNSSEC that are available in this version of hickory,
it's just upgrading to the API changes.

closes: #361

Author: wez

Cargo.lock

@@ -90,8 +90,8 @@ hdrhistogram = "7.5"
 hex = "0.4"
 # Be sure to update the link to the docs in docs/reference/kumo.dns/configure_resolver.md
 # to match the version that we are using when you update this dep
-hickory-resolver = "0.24"
-hickory-proto = "0.24"
+hickory-resolver = "0.25"
+hickory-proto = "0.25"
 hierarchical_hash_wheel_timer = {version="1.2", default-features=false, features=["fx-hash"]}
 human_bytes = "0.4.3"
 humanize-rs = "0.1"
@@ -110,7 +110,7 @@ lapin = {version="2.5", default-features=false, features=["native-tls"]}
 lexicmp = "0.1"
 libc = "0.2.139"
 linkme = "0.3"
-libunbound = {git="https://github.com/KumoCorp/libunbound-rs.git", rev="514258fa097d04236761fff2f97b4221ff4965e0"}
+libunbound = {git="https://github.com/KumoCorp/libunbound-rs.git", rev="19b39a551b3cf7cbc69a7eb24fef4801e66c6260"}
 lipsum = "0.9"
 log = "0.4"
 lru-cache = "0.1"

Cargo.toml

@@ -1,8 +1,8 @@
 use anyhow::Context;
 use arc_swap::ArcSwap;
-use hickory_resolver::error::ResolveResult;
 pub use hickory_resolver::proto::rr::rdata::tlsa::TLSA;
 use hickory_resolver::proto::rr::RecordType;
+use hickory_resolver::proto::ProtoError;
 pub use hickory_resolver::Name;
 use kumo_address::host::HostAddress;
 use kumo_log_types::ResolvedAddress;
@@ -131,7 +131,7 @@ pub struct MailExchanger {
     expires: Option<Instant>,
 }
 
-pub fn fully_qualify(domain_name: &str) -> ResolveResult<Name> {
+pub fn fully_qualify(domain_name: &str) -> Result<Name, ProtoError> {
     let mut name = Name::from_str_relaxed(domain_name)?.to_lowercase();
 
     // Treat it as fully qualified