Skip to content

Commit d8436f7

Browse files
authored
Codebase refactor (#442)
* files reorganization (#432) * fix podspec * only include swift files * Fix broken readme paths (#433) * update links * fix french link * split skeleton debug to public and internal methods (#434) * Add build phase to execute SwiftLint (#435) * update tvOS tests * Refactor Extensions folder (#436) * Reorganize SkeletonAppearance (#437) * reorganize helpers and builders folders (#438) * Refactor flow and multilines (#439) * Reorganize collections folder (#440) * reorganize collections folder * update podspec * Refactor SkeletonView facade (#441) * reorganize collections folder * update podspec * refactor skeletonview facade * fix conflict * update iOS example * fix github workflows * update tvOS example project build settings
1 parent 35db69e commit d8436f7

153 files changed

Lines changed: 4503 additions & 2623 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/main.yml

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,12 @@ jobs:
1010
strategy:
1111
matrix:
1212
build-config:
13-
- { target: 'SkeletonView-iOS', destination: 'platform=iOS Simulator,name=iPhone 8', sdk: 'iphonesimulator' }
14-
- { target: 'SkeletonView-tvOS', destination: 'platform=tvOS Simulator,name=Apple TV', sdk: 'appletvsimulator' }
15-
- { target: 'SkeletonViewExample', destination: 'platform=iOS Simulator,name=iPhone 8', sdk: 'iphonesimulator' }
13+
- { scheme: 'SkeletonView iOS', destination: 'platform=iOS Simulator,name=iPhone 8', sdk: 'iphonesimulator' }
14+
- { scheme: 'SkeletonView tvOS', destination: 'platform=tvOS Simulator,name=Apple TV', sdk: 'appletvsimulator' }
15+
- { scheme: 'iOS Example', destination: 'platform=iOS Simulator,name=iPhone 8', sdk: 'iphonesimulator' }
16+
- { scheme: 'tvOS Example', destination: 'platform=tvOS Simulator,name=Apple TV', sdk: 'appletvsimulator' }
1617
steps:
1718
- uses: actions/checkout@v2
1819
- name: Build
19-
run: xcodebuild clean build -target '${{ matrix.build-config['target'] }}' -sdk '${{ matrix.build-config['sdk'] }}' -destination '${{ matrix.build-config['destination'] }}'
20+
run: xcodebuild clean build -workspace 'SkeletonView.xcworkspace' -scheme '${{ matrix.build-config['scheme'] }}' -sdk '${{ matrix.build-config['sdk'] }}' -destination '${{ matrix.build-config['destination'] }}'
21+

.swiftlint.yml

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
included:
2-
- Sources
2+
- SkeletonViewCore/Sources
33
disabled_rules:
44
- trailing_whitespace
55
- line_length
@@ -20,6 +20,8 @@ disabled_rules:
2020
- function_default_parameter_at_end
2121
- unowned_variable_capture
2222
- legacy_constructor
23+
- redundant_type_annotation
24+
- vertical_whitespace_opening_braces
2325
opt_in_rules:
2426
- multiline_arguments
2527
- multiline_parameters
@@ -49,18 +51,21 @@ opt_in_rules:
4951
- private_outlet
5052
- redundant_optional_initialization
5153
- redundant_set_access_control
52-
- redundant_type_annotation
5354
- sorted_first_last
5455
- switch_case_on_newline
5556
- unneeded_parentheses_in_closure_argument
5657
- unused_declaration
5758
- unused_import
58-
- vertical_whitespace_opening_braces
5959
- discouraged_optional_collection
60-
- enum_case_associated_values_counts
60+
- enum_case_associated_values_count
6161
- legacy_multiple
6262
- legacy_random
6363
indentation: 2
64+
type_name:
65+
min_length: 2
66+
max_length:
67+
warning: 50
68+
error: 60
6469
file_length:
6570
- 2500
6671
- 3000

.swiftpm/xcode/package.xcworkspace/contents.xcworkspacedata

Lines changed: 7 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Configs/SkeletonView-iOS.plist

Lines changed: 0 additions & 24 deletions
This file was deleted.

Example/TableView/Assets.xcassets/Contents.json

Lines changed: 0 additions & 6 deletions
This file was deleted.

Example/CollectionView/Assets.xcassets/AppIcon.appiconset/Contents.json renamed to Examples/CollectionView/Assets.xcassets/AppIcon.appiconset/Contents.json

File renamed without changes.
File renamed without changes.

Example/CollectionView/Assets.xcassets/avatar.imageset/Contents.json renamed to Examples/CollectionView/Assets.xcassets/avatar.imageset/Contents.json

File renamed without changes.

Example/CollectionView/Assets.xcassets/avatar.imageset/avatar.png renamed to Examples/CollectionView/Assets.xcassets/avatar.imageset/avatar.png

File renamed without changes.

0 commit comments

Comments
 (0)