Add the settings popover menu for the Overlays toggle#2523
Merged
Keavon merged 35 commits intoGraphiteEditor:masterfrom Apr 30, 2025
Merged
Add the settings popover menu for the Overlays toggle#2523Keavon merged 35 commits intoGraphiteEditor:masterfrom
Keavon merged 35 commits intoGraphiteEditor:masterfrom
Conversation
Keavon
force-pushed
the
master
branch
3 times, most recently
from
aa7ff13 to
e11b57a
Compare
Keavon
changed the title
seam0s-dev
force-pushed
the
granular-overlays-settings
branch
from
c46f4b4 to
9a62c1c
Compare
seam0s-dev
force-pushed
the
granular-overlays-settings
branch
from
f5b4e4c to
9a62c1c
Compare
seam0s-dev
force-pushed
the
granular-overlays-settings
branch
from
728e57d to
938ad07
Compare
…ed selection outline check
seam0s-dev
force-pushed
the
granular-overlays-settings
branch
from
4477cc0 to
c4c5379
Compare
Contributor
Author
|
@Keavon Is it good to open now? |
Member
|
You'll need to first resolve the merge conflict. Then I can give it a test if you think it's ready for production, excepting for any feedback I find when testing that you didn't notice in your own (hopefully thorough) testing. |
Contributor
Author
|
At this point, I think it would be better to get you in the loop for review. More than bugs, I found out that I have added unintentional features that deviated away from your intentions. |
Member
|
Ok, in that case, please mark it as ready for review with a comment about that (which you just gave) so it turns from gray to green and I can look at it in my review queue. |
seam0s-dev
force-pushed
the
granular-overlays-settings
branch
from
59ac1cd to
b7fb453
Compare
seam0s-dev
force-pushed
the
granular-overlays-settings
branch
from
1719269 to
1634862
Compare
Member
|
!build |
Member
|
One last issue: the master checkbox has stopped working (presumably as a result of your refactor to the |
|
seam0s-dev
force-pushed
the
granular-overlays-settings
branch
from
272d45b to
5770a93
Compare
Keavon
force-pushed
the
granular-overlays-settings
branch
from
1696656 to
fd5629b
Compare
Keavon
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added options on the frontend to selectively disable/enable certain types of overlays.