Skip to content

Commit dafb2ad

Browse files
authored
Merge pull request #118 from rosmo/helm-chart-ns
Add possibility to disable namespace creation in Helm chart
2 parents 6dbba46 + c528022 commit dafb2ad

5 files changed

Lines changed: 25 additions & 11 deletions

File tree

Makefile

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,3 +140,11 @@ release-image: docker-build
140140
# Push release image
141141
release-push: release-image
142142
${DOCKER_BIN} push ${RELEASE_IMG}:${VERSION}
143+
144+
helm: helm-docs helm-lint
145+
146+
helm-lint:
147+
helm lint deploy/chart
148+
149+
helm-docs:
150+
helm-docs

deploy/chart/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ type: application
99
# This is the chart version. This version number should be incremented each time you make changes
1010
# to the chart and its templates, including the app version.
1111
# Versions are expected to follow Semantic Versioning (https://semver.org/)
12-
version: 0.1.0
12+
version: 0.1.1
1313

1414
# This is the version number of the application being deployed. This version number should be
1515
# incremented each time you make changes to the application. Versions are not expected to

deploy/chart/README.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ A Helm chart for autoneg-controller-manager.
1010
|-----|------|---------|-------------|
1111
| annotations | object | `{}` | |
1212
| autoscaling | object | `{}` | Autoscaling ranges, set minReplicas and maxReplicas if required |
13+
| createNamespace | bool | `true` | |
1314
| gke_autoneg_controller.args[0] | string | `"--health-probe-bind-address=:8081"` | |
1415
| gke_autoneg_controller.args[1] | string | `"--metrics-bind-address=127.0.0.1:8080"` | |
1516
| gke_autoneg_controller.args[2] | string | `"--leader-elect"` | |
@@ -52,4 +53,4 @@ A Helm chart for autoneg-controller-manager.
5253
| strategy.type | string | `"RollingUpdate"` | |
5354

5455
----------------------------------------------
55-
Autogenerated from chart metadata using [helm-docs v1.12.0](https://github.com/norwoodj/helm-docs/releases/v1.12.0)
56+
Autogenerated from chart metadata using [helm-docs v1.13.1](https://github.com/norwoodj/helm-docs/releases/v1.13.1)

deploy/chart/templates/namespace.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
{{ if eq .Values.createNamespace true }}
12
---
23
apiVersion: v1
34
kind: Namespace
@@ -9,3 +10,4 @@ metadata:
910
{{- toYaml . | nindent 4 }}
1011
{{- end }}
1112
name: {{ include "autoneg.namespace" . | quote }}
13+
{{ end }}

deploy/chart/values.yaml

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
---
22
name: &name autoneg-controller-manager
33

4-
annotations: {}
4+
createNamespace: true
5+
6+
annotations:
7+
{}
58
# annontated: true
69

710
labels:
@@ -44,21 +47,21 @@ kube_rbac_proxy:
4447
allowPrivilegeEscalation: false
4548
privileged: false
4649
args:
47-
- --secure-listen-address=0.0.0.0:8443
48-
- --upstream=http://127.0.0.1:8080/
49-
- --logtostderr=true
50-
- --v=10
50+
- --secure-listen-address=0.0.0.0:8443
51+
- --upstream=http://127.0.0.1:8080/
52+
- --logtostderr=true
53+
- --v=10
5154
port: 8443
5255

5356
gke_autoneg_controller:
5457
name: manager
5558
image: ghcr.io/googlecloudplatform/gke-autoneg-controller/gke-autoneg-controller:latest
5659
command:
57-
- /manager
60+
- /manager
5861
args:
59-
- --health-probe-bind-address=:8081
60-
- --metrics-bind-address=127.0.0.1:8080
61-
- --leader-elect
62+
- --health-probe-bind-address=:8081
63+
- --metrics-bind-address=127.0.0.1:8080
64+
- --leader-elect
6265
securityContext:
6366
allowPrivilegeEscalation: false
6467
privileged: false

0 commit comments

Comments
 (0)