Fix nil value issue with coercible floats (#30)

TheWudu · web-flow · commit 31408ae6dc15 · 2022-03-04T12:13:12.000+01:00
Fix nil crash issue with CoercibleType definition
diff --git a/.approvals b/.approvals
diff --git a/.gitignore b/.gitignore
@@ -8,4 +8,5 @@
 /tmp/
 /bin/
 *.swp
+.approvals
 spec/examples.txt
diff --git a/Changelog.md b/Changelog.md
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## Unreleased
 
+## [0.7.1] - 2022-03-04
+### Fixed
+- Float coercion: check for nil before coercion
+
 ## [0.7.0] - 2022-02-25
 ### Added
 - Lambda definitions can now be failed with custom error messages
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    definition (0.7.0)
+    definition (0.7.1)
       activesupport
       i18n
 
diff --git a/lib/definition/types/type.rb b/lib/definition/types/type.rb
@@ -14,7 +14,7 @@ def initialize(name, klass, &coerce)
       end
 
       def conform(value)
-        value = coerce.call(value) if coerce && !valid?(value)
+        value = coerce.call(value) if value && coerce && !valid?(value)
 
         try_conform(value)
       end
diff --git a/lib/definition/version.rb b/lib/definition/version.rb
@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Definition
-  VERSION = "0.7.0"
+  VERSION = "0.7.1"
 end
diff --git a/spec/approvals/definitioncoercibletype/with_incoercible_nil_value/behaves_like_it_does_not_conform/has_correct_error_hash.approved.json b/spec/approvals/definitioncoercibletype/with_incoercible_nil_value/behaves_like_it_does_not_conform/has_correct_error_hash.approved.json
@@ -0,0 +1,3 @@
+{
+  "": "<Definition::ConformError \n\t message: \"Is of type NilClass instead of Float\", \n\t json_pointer: \"/\">"
+}
diff --git a/spec/approvals/definitioncoercibletype/with_incoercible_nil_value/behaves_like_it_does_not_conform/has_correct_error_hash.received.json b/spec/approvals/definitioncoercibletype/with_incoercible_nil_value/behaves_like_it_does_not_conform/has_correct_error_hash.received.json
@@ -0,0 +1,3 @@
+{
+  "": "<Definition::ConformError \n\t message: \"Is of type NilClass instead of Float\", \n\t json_pointer: \"/\">"
+}
diff --git a/spec/approvals/definitioncoercibletype/with_incoercible_nil_value/behaves_like_it_does_not_conform/has_correct_error_message.approved.txt b/spec/approvals/definitioncoercibletype/with_incoercible_nil_value/behaves_like_it_does_not_conform/has_correct_error_message.approved.txt
@@ -0,0 +1 @@
+Is of type NilClass instead of Float
diff --git a/spec/approvals/definitioncoercibletype/with_incoercible_nil_value/behaves_like_it_does_not_conform/has_correct_error_message.received.txt b/spec/approvals/definitioncoercibletype/with_incoercible_nil_value/behaves_like_it_does_not_conform/has_correct_error_message.received.txt
@@ -0,0 +1 @@
+Is of type NilClass instead of Float
diff --git a/spec/approvals/definitioncoercibletype/with_incoercible_nil_value/behaves_like_it_does_not_conform/has_correct_errors.approved.txt b/spec/approvals/definitioncoercibletype/with_incoercible_nil_value/behaves_like_it_does_not_conform/has_correct_errors.approved.txt
@@ -0,0 +1,3 @@
+[0] <Definition::ConformError 
+	 message: "Is of type NilClass instead of Float", 
+	 json_pointer: "/">
diff --git a/spec/approvals/definitioncoercibletype/with_incoercible_nil_value/behaves_like_it_does_not_conform/has_correct_errors.received.txt b/spec/approvals/definitioncoercibletype/with_incoercible_nil_value/behaves_like_it_does_not_conform/has_correct_errors.received.txt
@@ -0,0 +1,3 @@
+[0] <Definition::ConformError 
+	 message: "Is of type NilClass instead of Float", 
+	 json_pointer: "/">
diff --git a/spec/integration/coercible_type_spec.rb b/spec/integration/coercible_type_spec.rb
@@ -15,4 +15,10 @@
 
     it_behaves_like "it does not conform"
   end
+
+  context "with incoercible nil value" do
+    let(:value) { nil }
+
+    it_behaves_like "it does not conform"
+  end
 end

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+{`
	`2`	`+ "": "<Definition::ConformError \n\t message: \"Is of type NilClass instead of Float\", \n\t json_pointer: \"/\">"`
	`3`	`+}`