Skip to content

Commit 8d00cb9

Browse files
authored
v300: Pre-release tasks (#470)
1 parent 151cde2 commit 8d00cb9

18 files changed

Lines changed: 213 additions & 198 deletions

File tree

app/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ android {
2626
}
2727

2828
// Optional input to apply the external signing configuration for the sample viewer
29-
// Example: ./gradlew assembleRelease -PsigningPropsFilePath=absolute-file-path/signing.properties -D build=200.8.0
29+
// Example: ./gradlew assembleRelease -PsigningPropsFilePath=absolute-file-path/signing.properties -D build=300.0.0
3030
val signingPropsFilePath = project.findProperty("signingPropsFilePath").toString()
3131
val signingPropsFile = rootProject.file(signingPropsFilePath)
3232

app/src/main/java/com/esri/arcgismaps/kotlin/sampleviewer/ui/screens/about/AboutScreen.kt

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ import androidx.compose.runtime.setValue
4949
import androidx.compose.ui.Alignment
5050
import androidx.compose.ui.Modifier
5151
import androidx.compose.ui.draw.clip
52-
import androidx.compose.ui.platform.LocalConfiguration
5352
import androidx.compose.ui.platform.LocalContext
53+
import androidx.compose.ui.platform.LocalWindowInfo
5454
import androidx.compose.ui.res.painterResource
5555
import androidx.compose.ui.res.stringResource
5656
import androidx.compose.ui.text.font.FontWeight
@@ -62,6 +62,7 @@ import com.esri.arcgismaps.kotlin.sampleviewer.R
6262
import com.esri.arcgismaps.kotlin.sampleviewer.ui.components.SampleViewerTopAppBar
6363
import com.esri.arcgismaps.sample.sampleslib.theme.SampleAppTheme
6464
import androidx.core.net.toUri
65+
import java.util.Calendar
6566

6667
/**
6768
* Showcase information about the application.
@@ -109,7 +110,7 @@ private fun AboutIcon() {
109110
horizontalArrangement = Arrangement.Center,
110111
verticalAlignment = Alignment.CenterVertically
111112
) {
112-
val size = (LocalConfiguration.current.screenWidthDp * 0.20).dp
113+
val size = LocalWindowInfo.current.containerDpSize.width * 0.20f
113114
Image(
114115
modifier = Modifier.size(size),
115116
painter = painterResource(com.esri.arcgismaps.sample.sampleslib.R.drawable.arcgis_maps_sdks_64),
@@ -133,9 +134,10 @@ private fun TitleAndCopyrightSection() {
133134
fontWeight = FontWeight.Bold,
134135
style = MaterialTheme.typography.titleMedium
135136
)
137+
val currentYear = Calendar.getInstance().get(Calendar.YEAR)
136138
Text(
137139
modifier = Modifier.align(Alignment.CenterHorizontally),
138-
text = stringResource(R.string.copyright_text),
140+
text = stringResource(R.string.copyright_text, currentYear),
139141
textAlign = TextAlign.Center,
140142
style = MaterialTheme.typography.labelMedium
141143
)

app/src/main/java/com/esri/arcgismaps/kotlin/sampleviewer/ui/screens/home/HomeCategoryScreen.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ import androidx.compose.ui.geometry.Offset
5252
import androidx.compose.ui.input.nestedscroll.NestedScrollConnection
5353
import androidx.compose.ui.input.nestedscroll.NestedScrollSource
5454
import androidx.compose.ui.input.nestedscroll.nestedScroll
55-
import androidx.compose.ui.platform.LocalConfiguration
55+
import androidx.compose.ui.platform.LocalWindowInfo
5656
import androidx.compose.ui.res.stringResource
5757
import androidx.compose.ui.tooling.preview.Preview
5858
import androidx.compose.ui.unit.dp
@@ -75,8 +75,8 @@ fun HomeCategoryScreen(
7575
onNavigateToSearch: () -> Unit,
7676
onNavigateToCategory: (SampleCategory) -> Unit,
7777
) {
78-
val config = LocalConfiguration.current
79-
val layoutSpacing by remember { mutableStateOf(0.03f * config.screenWidthDp.dp) }
78+
val window = LocalWindowInfo.current
79+
val layoutSpacing by remember { mutableStateOf(0.03f * window.containerDpSize.width) }
8080
val isVisible = rememberSaveable { mutableStateOf(true) }
8181
val nestedScrollConnection = remember {
8282
object : NestedScrollConnection {

app/src/main/res/values/strings.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<string name="about_section">About</string>
55
<string name="app_version">App Version</string>
66
<string name="SDK_version">SDK Version</string>
7-
<string name="copyright_text">Copyright © 2015–2024 Esri.\nAll Rights Reserved.</string>
7+
<string name="copyright_text">Copyright © 2015–%1$d Esri.\nAll Rights Reserved.</string>
88
<string name="about_title">ArcGIS Maps SDK Sample Viewer</string>
99
<string name="powered_by">Powered By</string>
1010
<string name="ArcGIS_Maps_SDK_Toolkit">ArcGIS Maps SDK Toolkit for Kotlin</string>

gradle/libs.versions.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[versions]
22

33
# ArcGIS Maps SDK for Kotlin version
4-
arcgisMapsKotlinVersion = "300.0.0-4922"
4+
arcgisMapsKotlinVersion = "300.0.0-4928"
55

66
### Android versions
77
androidGradlePlugin = "8.13.2"

samples-lib/src/main/java/com/esri/arcgismaps/sample/sampleslib/components/BottomSheet.kt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package com.esri.arcgismaps.sample.sampleslib.components
1818

1919
import android.content.res.Configuration
2020
import androidx.compose.animation.AnimatedVisibility
21+
import androidx.compose.animation.animateContentSize
2122
import androidx.compose.animation.fadeIn
2223
import androidx.compose.animation.fadeOut
2324
import androidx.compose.animation.slideInVertically
@@ -33,13 +34,16 @@ import androidx.compose.foundation.layout.fillMaxWidth
3334
import androidx.compose.foundation.layout.height
3435
import androidx.compose.foundation.layout.padding
3536
import androidx.compose.foundation.layout.systemBarsPadding
37+
import androidx.compose.foundation.rememberScrollState
38+
import androidx.compose.foundation.verticalScroll
3639
import androidx.compose.material.icons.Icons
3740
import androidx.compose.material.icons.filled.Close
3841
import androidx.compose.material3.FilledTonalIconButton
3942
import androidx.compose.material3.Icon
4043
import androidx.compose.material3.MaterialTheme
4144
import androidx.compose.material3.Surface
4245
import androidx.compose.material3.Text
46+
import androidx.compose.material3.TopAppBarDefaults
4347
import androidx.compose.runtime.Composable
4448
import androidx.compose.ui.Alignment
4549
import androidx.compose.ui.Modifier
@@ -64,6 +68,7 @@ fun BottomSheet(
6468
Box(
6569
modifier = Modifier
6670
.fillMaxSize()
71+
.padding(top = TopAppBarDefaults.TopAppBarExpandedHeight)
6772
.systemBarsPadding()
6873
) {
6974
AnimatedVisibility(
@@ -75,6 +80,9 @@ fun BottomSheet(
7580
SampleAppTheme {
7681
Surface {
7782
Column(
83+
modifier = Modifier
84+
.verticalScroll(rememberScrollState())
85+
.animateContentSize(),
7886
verticalArrangement = Arrangement.spacedBy(8.dp),
7987
horizontalAlignment = Alignment.CenterHorizontally
8088
) {

samples/add-scene-layer-from-service/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Pan and zoom to explore the scene.
3131

3232
## About the data
3333

34-
This sample shows a [Portland, Oregon USA Scene](https://www.arcgis.com/home/item.html?id=2b721b9e7bef45e2b7ff78a398a33acc) hosted on ArcGIS Online.
34+
This sample shows data from [Esri 3D Buildings](https://www.arcgis.com/home/item.html?id=b8fec5af7dfe4866b1b8ac2d2800f282) in Portland, Oregon.
3535

3636
## Tags
3737

samples/add-scene-layer-from-service/src/main/java/com/esri/arcgismaps/sample/addscenelayerfromservice/components/AddSceneLayerFromServiceViewModel.kt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ import kotlinx.coroutines.launch
3434
class AddSceneLayerFromServiceViewModel(app: Application) : AndroidViewModel(app) {
3535
// URL of the Portland buildings scene server
3636
private val portlandBuildingsSceneLayerUrl =
37-
"https://tiles.arcgis.com/tiles/P3ePLMYs2RVChkJx/arcgis/rest/services/Buildings_Portland/SceneServer"
37+
"https://basemaps3d.arcgis.com/arcgis/rest/services/Esri3D_Buildings_v1/SceneServer"
3838

3939
// URL of the world elevation tiled elevation source
4040
private val worldElevationServiceUrl =
@@ -53,9 +53,9 @@ class AddSceneLayerFromServiceViewModel(app: Application) : AndroidViewModel(app
5353
// Camera location point (Portland, OR)
5454
private val cameraLocation: Point by lazy {
5555
Point(
56-
x = -122.66949,
57-
y = 45.51869,
58-
z = 227.0,
56+
x = -122.670,
57+
y = 45.517,
58+
z = 175.0,
5959
spatialReference = SpatialReference.wgs84()
6060
)
6161
}
@@ -64,8 +64,8 @@ class AddSceneLayerFromServiceViewModel(app: Application) : AndroidViewModel(app
6464
private val camera: Camera by lazy {
6565
Camera(
6666
locationPoint = cameraLocation,
67-
heading = 219.0,
68-
pitch = 82.0,
67+
heading = 215.0,
68+
pitch = 75.0,
6969
roll = 0.0
7070
)
7171
}

0 commit comments

Comments
 (0)