Hi, I found 3 build issues while working with the solution. I have fixes ready on my fork but PR creation is restricted to collaborators.
The x86 PostBuildEvent in DWSIM.vbproj references PlatformFiles\Windows32 which doesn't exist. The correct directory is Windows_32. Causes xcopy exit code 4.
System.Text.Json 8.0.5 is a transitive dependency from DWSIM.Simulate365 (via Microsoft.Graph/Azure.Core) but is missing from the main DWSIM project's packages.config and references. Also adds System.Text.Encodings.Web and Microsoft.Bcl.AsyncInterfaces.
ILMerge in DWSIM.Thermodynamics.StandaloneLibrary fails with "Unresolved assembly reference" for transitive dependencies from the Microsoft.Graph/Identity chain. Adds the missing library paths to ILMergeLibraryPath and sets ILMergeTransitive=false to prevent merging System.* type-forwarding assemblies.
Happy to submit proper PRs if given collaborator access, or feel free to cherry-pick directly from the branches above.
Hi, I found 3 build issues while working with the solution. I have fixes ready on my fork but PR creation is restricted to collaborators.
Fixes (branches on Selene29/dwsim)
1.
fix/xcopy-pathThe x86 PostBuildEvent in
DWSIM.vbprojreferencesPlatformFiles\Windows32which doesn't exist. The correct directory isWindows_32. Causes xcopy exit code 4.2.
fix/system-text-jsonSystem.Text.Json8.0.5 is a transitive dependency fromDWSIM.Simulate365(via Microsoft.Graph/Azure.Core) but is missing from the main DWSIM project'spackages.configand references. Also addsSystem.Text.Encodings.WebandMicrosoft.Bcl.AsyncInterfaces.3.
fix/ilmerge-transitiveILMerge in
DWSIM.Thermodynamics.StandaloneLibraryfails with "Unresolved assembly reference" for transitive dependencies from the Microsoft.Graph/Identity chain. Adds the missing library paths toILMergeLibraryPathand setsILMergeTransitive=falseto prevent merging System.* type-forwarding assemblies.Happy to submit proper PRs if given collaborator access, or feel free to cherry-pick directly from the branches above.