Merge pull request #69 from CeejayZSmith/perf/use-hashshet-for-dependencies

Optimize DependentObjectBasedAssetFilter by Using HashSet and Avoiding Redundant Dependency Collection

Author: Haruma-K

Assets/SmartAddresser/Editor/Core/Models/Shared/AssetGroups/AssetFilterImpl/DependentObjectBasedAssetFilter.cs

@@ -20,7 +20,7 @@ public sealed class DependentObjectBasedAssetFilter : AssetFilterBase
         [SerializeField] private bool _onlyDirectDependencies;
         [SerializeField] private ObjectListableProperty _object = new ObjectListableProperty();
 
-        private List<string> _dependentAssetPaths = new List<string>();
+        private HashSet<string> _dependentAssetPaths = new HashSet<string>();
         private bool _hasNullObject;
 
         /// <summary>
@@ -50,11 +50,19 @@ public override void SetupForMatching()
                 }
 
                 var path = AssetDatabase.GetAssetPath(obj);
+
+                // If we already have all the dependencies of 'path', we can skip
+                if (!_onlyDirectDependencies && _dependentAssetPaths.Contains(path) == true)
+                {
+                    continue;
+                }
+
                 var dependencies = AssetDatabase.GetDependencies(path, !_onlyDirectDependencies);
-                _dependentAssetPaths.AddRange(dependencies);
+                foreach (var dependency in dependencies)
+                {
+                    _dependentAssetPaths.Add(dependency);
+                }
             }
-
-            _dependentAssetPaths = _dependentAssetPaths.Distinct().ToList();
         }
 
         public override bool Validate(out AssetFilterValidationError error)