Skip to content

Commit ea855aa

Browse files
committed
code optimization for sleep related constants.
1 parent 20cda99 commit ea855aa

5 files changed

Lines changed: 13 additions & 8 deletions

File tree

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
export const HIGH_DEBT_THRESHOLD_HOURS = 1.5;
2+
export const GOOD_SLEEP_SCORE_THRESHOLD = 70;
3+
4+
export const DEBT_ZONE_COLOR = '#ff0000';
5+
export const SURPLUS_ZONE_COLOR = '#00ff00';
6+
export const DEFAULT_HYPNOGRAMS_SHOWN = 3;

SparkyFitnessFrontend/src/constants/sleepScience.ts

Lines changed: 0 additions & 2 deletions
This file was deleted.

SparkyFitnessFrontend/src/pages/Reports/SleepAnalyticsCharts.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,11 @@ import {
1010
type SleepEntry,
1111
} from '@/types';
1212
import { formatSecondsToHHMM } from '@/utils/timeFormatters';
13+
import {
14+
DEBT_ZONE_COLOR,
15+
SURPLUS_ZONE_COLOR,
16+
DEFAULT_HYPNOGRAMS_SHOWN,
17+
} from '@/constants/sleep';
1318
import {
1419
Activity,
1520
ChevronDown,
@@ -76,10 +81,6 @@ interface SleepAnalyticsChartsProps {
7681
latestSleepEntry?: SleepEntry | null;
7782
}
7883

79-
const DEBT_ZONE_COLOR = '#ff0000';
80-
const SURPLUS_ZONE_COLOR = '#00ff00';
81-
const DEFAULT_HYPNOGRAMS_SHOWN = 3;
82-
8384
const SleepAnalyticsCharts = ({
8485
sleepAnalyticsData,
8586
sleepHypnogramData,

SparkyFitnessFrontend/src/pages/Reports/SleepAnalyticsTable.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import { formatSecondsToHHMM } from '@/utils/timeFormatters';
1919
import {
2020
HIGH_DEBT_THRESHOLD_HOURS,
2121
GOOD_SLEEP_SCORE_THRESHOLD,
22-
} from '@/constants/sleepScience';
22+
} from '@/constants/sleep';
2323

2424
interface SleepAnalyticsTableProps {
2525
combinedSleepData: CombinedSleepData[];

SparkyFitnessFrontend/src/pages/Reports/SleepReport.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import { formatSecondsToHHMM } from '@/utils/timeFormatters';
1616
import {
1717
HIGH_DEBT_THRESHOLD_HOURS,
1818
GOOD_SLEEP_SCORE_THRESHOLD,
19-
} from '@/constants/sleepScience';
19+
} from '@/constants/sleep';
2020
import SleepAnalyticsCharts from './SleepAnalyticsCharts';
2121
import SleepAnalyticsTable from './SleepAnalyticsTable';
2222

0 commit comments

Comments
 (0)