Merge pull request #834 from Sim-sat/no-explicit-any-hooks

fix(lint): no-explicit-any for components, hooks, lib

Author: CodeWithCJ

SparkyFitnessFrontend/src/components/ExerciseActivityDetailsEditor.tsx

@@ -11,8 +11,7 @@ export interface ActivityDetailKeyValuePair {
   id?: string; // Optional for new entries, will be generated by backend
   key: string; // Maps to detail_type in backend
   value: string; // Stored within detail_data as JSONB in backend
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  detail_data?: any; // Add detail_data to the interface
+  detail_data?: unknown;
   provider_name?: string; // Optional, will default to 'Manual' in backend
   detail_type?: string; // Optional, will default to 'Custom Field' in backend
 }

SparkyFitnessFrontend/src/components/FoodSearch/BarcodeScanner.tsx

@@ -31,6 +31,9 @@ interface BarcodeScannerProps {
   cameraFacing: 'front' | 'back';
 }
 
+interface AdvancedMediaTrackConstraints extends MediaTrackConstraintSet {
+  torch?: boolean;
+}
 const ENGINE_OPTIONS = [
   { value: 'zxing', label: '@zxing/library' },
   { value: 'html5-qrcode', label: 'html5-qrcode' },
@@ -152,8 +155,7 @@ const BarcodeScanner: React.FC<BarcodeScannerProps> = ({
     if (!currentTrack.current || !torchSupported || !torchEnabled) return;
     try {
       await currentTrack.current.applyConstraints({
-        // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        advanced: [{ torch: false } as any],
+        advanced: [{ torch: false } as AdvancedMediaTrackConstraints],
       });
       setTorchEnabled(false);
     } catch (error) {
@@ -165,8 +167,7 @@ const BarcodeScanner: React.FC<BarcodeScannerProps> = ({
     if (!currentTrack.current || !torchSupported) return;
     try {
       await currentTrack.current.applyConstraints({
-        // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        advanced: [{ torch: !torchEnabled } as any],
+        advanced: [{ torch: !torchEnabled } as AdvancedMediaTrackConstraints],
       });
       setTorchEnabled(!torchEnabled);
     } catch (error) {
@@ -193,8 +194,7 @@ const BarcodeScanner: React.FC<BarcodeScannerProps> = ({
         width: { ideal: 1280 }, // Lowering ideal might help mobile performance/compatibility
         frameRate: { ideal: 30 },
         focusMode: { ideal: 'continuous' },
-        // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      } as any, // Cast to allow custom properties
+      },
     };
 
     const start = async () => {

SparkyFitnessFrontend/src/components/FoodSearch/CustomFoodForm.tsx

@@ -134,8 +134,7 @@ const sanitizeGlycemicIndexFrontend = (
 };
 
 interface EnhancedCustomFoodFormProps {
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  onSave: (foodData: any) => void;
+  onSave: (foodData: Food) => void;
   food?: Food;
   initialVariants?: FoodVariant[]; // New prop for pre-populating variants
   visibleNutrients?: string[];

SparkyFitnessFrontend/src/components/OidcCallback.tsx

@@ -5,6 +5,13 @@ import { authClient } from '../lib/auth-client';
 import { useAuth } from '../hooks/useAuth';
 import { getErrorMessage } from '@/utils/api';
 
+interface ExtendedAuthUser {
+  id: string;
+  email: string;
+  name: string;
+  role?: string;
+}
+
 const OidcCallback: React.FC = () => {
   const [error, setError] = useState<string | null>(null);
   const navigate = useNavigate();
@@ -31,16 +38,16 @@ const OidcCallback: React.FC = () => {
         }
 
         if (session?.user) {
+          const user = session.user as unknown as ExtendedAuthUser;
           // Synchronize local AuthContext with Better Auth session
           signIn(
-            session.user.id,
-            session.user.id, // Better Auth user is always the active user initially
-            session.user.email,
-            // eslint-disable-next-line @typescript-eslint/no-explicit-any
-            (session.user as any).role || 'user',
+            user.id,
+            user.id,
+            user.email,
+            user.role || 'user',
             'oidc',
-            false, // Don't navigate automatically, we do it below
-            session.user.name
+            false,
+            user.name
           );
           navigate('/');
         } else {

SparkyFitnessFrontend/src/components/Onboarding/OnBoardingSteps.tsx

@@ -46,8 +46,10 @@ export const OnboardingSteps = ({
 }: OnboardingStepsProps) => {
   const { t } = useTranslation();
 
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  const handleSelect = (field: keyof FormData, value: any) => {
+  const handleSelect = (
+    field: keyof FormData,
+    value: string | boolean | number
+  ) => {
     setFormData((prev) => ({ ...prev, [field]: value }));
     setTimeout(() => nextStep(), 250);
   };

SparkyFitnessFrontend/src/hooks/Settings/useApiKeys.ts

@@ -115,15 +115,21 @@ export const useToggleApiKeyMutation = () => {
   });
 };
 
+interface ApiKeyPlugin {
+  deleteAllExpiredApiKeys: (
+    options: Record<string, unknown>
+  ) => Promise<{ error: unknown }>;
+}
+
 export const useCleanupApiKeysMutation = () => {
   const queryClient = useQueryClient();
   const { t } = useTranslation();
 
   return useMutation({
     mutationFn: async () => {
-      const { error } =
-        await // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        (authClient.apiKey as any).deleteAllExpiredApiKeys({});
+      const { error } = await (
+        authClient.apiKey as unknown as ApiKeyPlugin
+      ).deleteAllExpiredApiKeys({});
       if (error) throw error;
     },
     onSuccess: () => {

SparkyFitnessFrontend/src/hooks/useAuth.tsx

@@ -11,7 +11,7 @@ import { useNavigate } from 'react-router-dom';
 import { authClient } from '../lib/auth-client';
 import { fetchIdentityUser, switchUserContext } from '@/api/Auth/auth';
 
-interface User {
+export interface User {
   id: string;
   activeUserId: string;
   email: string;
@@ -21,6 +21,16 @@ interface User {
   mfaEmailEnabled: boolean;
 }
 
+interface ExtendedSessionUser {
+  id: string;
+  email: string;
+  name: string | null;
+  activeUserId?: string;
+  role?: string;
+  twoFactorEnabled?: boolean;
+  mfaEmailEnabled?: boolean;
+}
+
 interface AuthContextType {
   user: User | null;
   loading: boolean;
@@ -47,8 +57,7 @@ export const AuthProvider: React.FC<{ children: ReactNode }> = ({
   const [user, setUser] = useState<User | null>(null);
   const [isSyncing, setIsSyncing] = useState(true); // Track initial hydration
   const navigate = useNavigate();
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  const prevSessionRef = React.useRef<any>(null);
+  const prevSessionRef = React.useRef<typeof session>(null);
 
   // Only show global loading during initial hydration (isSyncing).
   // Ignoring sessionLoading avoids unmounting components (like Auth/MFA) during background re-fetches.
@@ -60,34 +69,21 @@ export const AuthProvider: React.FC<{ children: ReactNode }> = ({
   useEffect(() => {
     // Log when session changes to identify refresh triggers
     if (session !== prevSessionRef.current) {
-      const prevUser = prevSessionRef.current?.user?.id;
-      const newUser = session?.user?.id;
-      const isSameUser = prevUser === newUser;
-
-      // console.log('[Auth Hook] Session update detected:', {
-      //   timestamp: new Date().toLocaleTimeString(),
-      //   isSameUser,
-      //   prevUserId: prevUser,
-      //   newUserId: newUser,
-      //   trigger: isSameUser ? 'POTENTIAL UNWANTED REFRESH' : 'USER CHANGED',
-      // });
-
       prevSessionRef.current = session;
     }
 
     // Only process if session has actual user data AND it's different from what we have
     if (session?.user && (!user || user.id !== session.user.id)) {
-      const sessionUser = {
-        id: session.user.id,
-        // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        activeUserId: (session.user as any).activeUserId || session.user.id,
-        email: session.user.email,
-        fullName: session.user.name || null,
-        // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        role: (session.user as any).role || 'user',
-        twoFactorEnabled: !!session.user.twoFactorEnabled,
-        // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        mfaEmailEnabled: !!(session.user as any).mfaEmailEnabled,
+      const extUser = session.user as unknown as ExtendedSessionUser;
+
+      const sessionUser: User = {
+        id: extUser.id,
+        activeUserId: extUser.activeUserId || extUser.id,
+        email: extUser.email,
+        fullName: extUser.name || null,
+        role: extUser.role || 'user',
+        twoFactorEnabled: !!extUser.twoFactorEnabled,
+        mfaEmailEnabled: !!extUser.mfaEmailEnabled,
       };
 
       //console.log('[Auth Hook] Setting user state from session:', sessionUser.id);
@@ -96,8 +92,7 @@ export const AuthProvider: React.FC<{ children: ReactNode }> = ({
       // Fetch Authoritative Data (Active Context)
       // This runs on every session update to ensure we are strictly in sync with the backend.
       fetchIdentityUser()
-        // eslint-disable-next-line @typescript-eslint/no-explicit-any
-        .then((realUserData: any) => {
+        .then((realUserData) => {
           setUser((prev) => {
             if (!prev) return prev;
             if (
@@ -127,7 +122,6 @@ export const AuthProvider: React.FC<{ children: ReactNode }> = ({
       setIsSyncing(false);
     } else if (session?.user && user && user.id === session.user.id) {
       // Same user - just update 2FA status if changed
-      // console.log('[Auth Hook] Session re-poll detected, skipping unnecessary update for same user');
       setIsSyncing(false);
     }
   }, [session, user]);

SparkyFitnessFrontend/src/lib/scannerEngines/QuaggaEngine.ts

@@ -1,6 +1,12 @@
-import Quagga from '@ericblade/quagga2';
+import Quagga, { InputStreamType } from '@ericblade/quagga2';
 import type { BarcodeScannerEngine } from './EngineInterface';
 
+interface QuaggaInputStreamConfig {
+  type: InputStreamType;
+  target: HTMLElement;
+  constraints?: MediaTrackConstraints;
+}
+
 export class QuaggaEngine implements BarcodeScannerEngine {
   private containerElement: HTMLElement | null = null;
   private callback: ((code: string) => void) | null = null;
@@ -18,8 +24,7 @@ export class QuaggaEngine implements BarcodeScannerEngine {
 
     this.isScanning = true;
 
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    const liveStreamConfig: any = {
+    const liveStreamConfig: QuaggaInputStreamConfig = {
       type: 'LiveStream',
       target: this.containerElement!,
     };

SparkyFitnessFrontend/src/lib/scannerEngines/ZxingEngine.ts

@@ -50,8 +50,7 @@ export class ZxingEngine implements BarcodeScannerEngine {
     this.codeReader.decodeFromVideoDevice(
       this.currentDeviceId,
       this.videoElement,
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      (result: Result | null, err: any) => {
+      (result: Result | null, err: unknown) => {
         if (result) {
           const text = result.getText();
           if (this.callback) this.callback(text);

SparkyFitnessFrontend/src/main.tsx

@@ -29,10 +29,8 @@ declare module '@tanstack/react-query' {
 }
 // helper function to allow variables in toast messages
 const resolveMessage = (
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  message: string | ((...args: any[]) => string) | undefined,
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  ...args: any[]
+  message: string | ((...args: unknown[]) => string) | undefined,
+  ...args: unknown[]
 ): string | undefined => {
   if (typeof message === 'function') {
     return message(...args);