🐛 fix subset function to use np.isin for better readability and performance (#585)

* 🐛 fix subset function to use np.isin for better readability and performance

* 🐛 fix order_by_date function to use np.isin for improved performance and clarity

Author: selipot

clouddrift/adapters/gdp/__init__.py

@@ -185,7 +185,7 @@ def order_by_date(df: pd.DataFrame, idx: list[int]) -> list[int]:  # noqa: F821
     idx : list
         Unique set of drifter IDs sorted by their start date.
     """
-    return df.ID[np.where(np.in1d(df.ID, idx))[0]].values  # type: ignore
+    return df.ID[np.where(np.isin(df.ID, idx))[0]].values  # type: ignore
 
 
 def fetch_netcdf(url: str, file: str):

clouddrift/ragged.py

@@ -762,7 +762,7 @@ def subset(
         mask_obs
     ]
     mask_row = np.logical_and(
-        mask_row, np.in1d(ds[id_var_name], np.unique(ids_with_mask_obs))
+        mask_row, np.isin(ds[id_var_name], np.unique(ids_with_mask_obs))
     )
 
     # reset mask_obs to True if we want to keep complete rows