build UPDATE avoid redefining HAVE_REGEX_H#2515
Merged
Merged
Conversation
michalvasko
reviewed
May 22, 2026
Member
michalvasko
left a comment
michalvasko
left a comment
There was a problem hiding this comment.
I am unsure about this change. Is it always okay to rely on some other check that the one in the library? Other possibility would be to rename all these macros and add LY_ as their prefix, for example.
Avoids conflicts during build with external libraries that already define HAVE_REGEX_H. Signed-off-by: Jeremie Leska <jeremie.leska@6wind.com>
michalvasko
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids conflicts during build with external libraries that already define HAVE_REGEX_H.
Fixes: 0ba69b4 ("build UPDATE optional regex dependency")