Skip to content

Commit df52142

Browse files
RALPH: fix: NameError in run_compression — used undefined job_name instead of compress_job_name (Issue #111)
The function parameter is `compress_job_name` but 5 f-string log statements referenced the undefined variable `job_name`, causing a NameError on every compression job. The error handler also used `job_name`, so the original error was masked by a second NameError. Files changed: - vms/tools.py (5 log lines: job_name → compress_job_name) Co-Authored-By: Claude Opus 4.6 <[email protected]>
1 parent e9e198e commit df52142

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

vms/tools.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ def run_compression(compress_job_name: str):
3131
ext = _get_extension(job.original_file_name)
3232
input_path = os.path.join(tmpdir, f"input{ext}")
3333

34-
frappe.logger("vms").info(f"Downloading source file for compression: {job_name}")
34+
frappe.logger("vms").info(f"Downloading source file for compression: {compress_job_name}")
3535
download_url = generate_presigned_download_url(job.original_r2_key, job.original_file_name)
3636
urlretrieve(download_url, input_path)
3737

@@ -44,7 +44,7 @@ def run_compression(compress_job_name: str):
4444
output_name = _make_output_filename(job.original_file_name)
4545
output_path = os.path.join(tmpdir, output_name)
4646

47-
frappe.logger("vms").info(f"Starting ffmpeg compression: {job_name}")
47+
frappe.logger("vms").info(f"Starting ffmpeg compression: {compress_job_name}")
4848
_ffmpeg_compress(input_path, output_path)
4949

5050
job.progress = 80
@@ -56,7 +56,7 @@ def run_compression(compress_job_name: str):
5656
compressed_size = os.path.getsize(output_path)
5757
r2_key = f"tools/{uuid.uuid4().hex}.mp4"
5858

59-
frappe.logger("vms").info(f"Uploading compressed file to R2: {job_name}")
59+
frappe.logger("vms").info(f"Uploading compressed file to R2: {compress_job_name}")
6060
upload_r2_object(r2_key, output_path, "video/mp4")
6161

6262
# Update job record
@@ -70,10 +70,10 @@ def run_compression(compress_job_name: str):
7070
frappe.db.commit()
7171

7272
_publish_progress(job)
73-
frappe.logger("vms").info(f"Compression complete: {job_name}")
73+
frappe.logger("vms").info(f"Compression complete: {compress_job_name}")
7474

7575
except Exception as e:
76-
frappe.logger("vms").error(f"Compression failed for {job_name}: {e}")
76+
frappe.logger("vms").error(f"Compression failed for {compress_job_name}: {e}")
7777
job.reload()
7878
job.status = "Error"
7979
job.error_message = str(e)[:500]

0 commit comments

Comments
 (0)