Commit 9f25fc3
committed
fix(omnivoice): remove erroneous transpose in OmniVoiceConv1d
OmniVoiceConv1d initialized weights as [out,k,in] (MLX format) but
then transposed them to [out,in,k] inside callAsFunction before
passing to MLX.conv1d. This permuted every conv1d weight in the
vocoder encoder/decoder, causing pure noise output even with
correctly-loaded checkpoint weights.
Remove the spurious transpose so the weight layout matches what
checkpoint and MLX.conv1d both expect.1 parent 5b6b6ca commit 9f25fc3
1 file changed
Lines changed: 4 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1015 | 1015 | | |
1016 | 1016 | | |
1017 | 1017 | | |
1018 | | - | |
1019 | | - | |
| 1018 | + | |
| 1019 | + | |
| 1020 | + | |
1020 | 1021 | | |
1021 | | - | |
| 1022 | + | |
1022 | 1023 | | |
1023 | 1024 | | |
1024 | 1025 | | |
| |||
0 commit comments