Simplify the code

Instead of explicitly checking some specific folder and specific indices simply loop backwards from the filename to the create folder and check if one of the paths is a match.

Avoid the copy pasting of regex, and constant index out of bounds exceptions being thrown.

Author: IsakNaslundBh

CodeComplianceTest_Engine/Query/Checks/IsValidCreateMethod.cs

@@ -48,32 +48,23 @@ public static Span IsValidCreateMethod(this MethodDeclarationSyntax node)
 
             string filePath = node.SyntaxTree.FilePath;
 
+            if (string.IsNullOrEmpty(filePath))
+                return node.Identifier.Span.ToSpan();
+
+            //Split the path, including the filename.
+            //Split by dot to get rid of extension in .cs file.
+            //Reverse to start with file and walk backwards
+            List<string> pathSplit = filePath.Split(System.IO.Path.DirectorySeparatorChar).Select(x => x.Split('.').First()).Reverse().ToList();
+
             foreach (string returnType in ReturnTypeCandidates(node))
             {
-                string fileName = "";
-
-                if (!string.IsNullOrEmpty(filePath))
+                foreach (string path in pathSplit)
                 {
-                    fileName = System.IO.Path.GetFileNameWithoutExtension(filePath);
-                    if (Regex.Match(returnType, $"((List|IEnumerable)<)?I?{fileName}(<.*>)?>?$").Success)
-                        return null; //File name matches return type exactly so this is valid. IsValidCreateMethodName will check if the method name matches the file name
-                }
-
-                //If file name does not exactly match the return type then we need to check if the return type is in a sub-folder in create
+                    if (path == "Create")   //Loop until we reach the create folder
+                        break;
 
-                List<string> pathSplit = filePath.Split(System.IO.Path.DirectorySeparatorChar).ToList();
-                int createIndex = pathSplit.IndexOf("Create");
-                if (createIndex == -1)
-                    return node.Identifier.Span.ToSpan(); //Evidently this create method isn't working for some reason - even though it should but this is as a protection/precaution
-
-                try
-                {
-                    if (Regex.Match(returnType, $"((List|IEnumerable)<)?I?{pathSplit[createIndex + 1]}(<.*>)?>?$").Success || Regex.Match(returnType, $"((List|IEnumerable)<)?I?{pathSplit[createIndex + 2]}(<.*>)?>?$").Success)
-                        return null; //The folder path after the 'Create' folder matches the return type so this is valid. IsValidCreateMethodName will check if the method name matches the file name
-                }
-                catch
-                {
-                    //In case createIndex + 1 || createIndex + 2 result in an out of bounds error - it means the check has failed and something isn't compliant so can pass through to returning the span
+                    if (Regex.Match(returnType, $"((List|IEnumerable)<)?I?{path}(<.*>)?>?$").Success)
+                        return null; //Name of file or folder matches return type exactly so this is valid. IsValidCreateMethodName will check if the method name matches the file name
                 }
             }
             return node.Identifier.Span.ToSpan(); //Create method file (name/path) and return type do not match as required