Merge pull request #114 from nge6427/mainnet

bignum fixes and other minor corrections

Author: Kristjan Kosic

helpers/bignum.js

@@ -30,7 +30,7 @@ var MAX = 1E9,                   // 0 to 1e+9
 	MAX_POWER = 1E6,               // 1 to 1e+6
 
 	// The maximum number of decimal places for operations involving division.
-	DECIMAL_PLACES = 20,           // 0 to MAX
+	DECIMAL_PLACES = 0,           // 0 to MAX
 
 	/*
 	 * The rounding mode used when rounding to the above decimal places, and when
@@ -51,11 +51,11 @@ var MAX = 1E9,                   // 0 to 1e+9
 
 	// The exponent value at and beneath which toString returns exponential notation.
 	// Number type: -7
-	TO_EXP_NEG = -7,                // 0 to -MAX
+	TO_EXP_NEG = -MAX,                // 0 to -MAX
 
 	// The exponent value at and above which toString returns exponential notation.
 	// Number type: 21
-	TO_EXP_POS = 21,                // 0 to MAX
+	TO_EXP_POS = MAX,                // 0 to MAX
 
 	// RANGE : [MIN_EXP, MAX_EXP]
 

helpers/constants.js

@@ -41,6 +41,6 @@ module.exports = {
 		distance: 3000000, // Distance between each milestone
 	},
 	signatureLength: 196,
-	totalAmount: 12500000000000000,
+	totalAmount: 12500000000000004, // TODO: Fix properly because this value exceeds JS Number precision
 	unconfirmedTransactionTimeOut: 10800 // 1080 blocks
 };

logic/account.js

@@ -131,7 +131,7 @@ function Account (scope, cb) {
 				required: true,
 				type: 'integer',
 				minimum: 0,
-				maximum: constants.totalAMount
+				maximum: constants.totalAmount
 			},
 			conv: Number,
 			expression: '("u_balance")::bigint'

logic/transaction.js

@@ -706,7 +706,7 @@ Transaction.prototype.apply = function (trs, block, sender, cb) {
 		return cb(senderBalance.error);
 	}
 
-	amount = amount.toNumber();
+	amount = parseInt(amount.toFixed(), 10);
 
 	this.scope.account.merge(sender.address, {
 		balance: -amount,
@@ -739,7 +739,7 @@ Transaction.prototype.apply = function (trs, block, sender, cb) {
 //
 Transaction.prototype.undo = function (trs, block, sender, cb) {
 	var amount = bignum(trs.amount.toString());
-	    amount = amount.plus(trs.fee.toString()).toNumber();
+	    amount = parseInt(amount.plus(trs.fee.toString()).toFixed(), 10);
 
 	this.scope.account.merge(sender.address, {
 		balance: amount,
@@ -783,7 +783,7 @@ Transaction.prototype.applyUnconfirmed = function (trs, sender, requester, cb) {
 		return cb(senderBalance.error);
 	}
 
-	amount = amount.toNumber();
+	amount = parseInt(amount.toFixed(), 10);
 
 	this.scope.account.merge(sender.address, {u_balance: -amount}, function (err, sender) {
 		if (err) {
@@ -808,7 +808,7 @@ Transaction.prototype.applyUnconfirmed = function (trs, sender, requester, cb) {
 //
 Transaction.prototype.undoUnconfirmed = function (trs, sender, cb) {
 	var amount = bignum(trs.amount.toString());
-	    amount = amount.plus(trs.fee.toString()).toNumber();
+	    amount = parseInt(amount.plus(trs.fee.toString()).toFixed(), 10);
 
 	this.scope.account.merge(sender.address, {u_balance: amount}, function (err, sender) {
 		if (err) {