Remove magic string from test collection specification

reisenberger · reisenberger · commit 64b21c82d79c · 2017-11-29T13:49:55.000Z
diff --git a/src/Polly.NetStandard11/Properties/AssemblyInfo.cs b/src/Polly.NetStandard11/Properties/AssemblyInfo.cs
@@ -3,7 +3,7 @@
 using System.Runtime.CompilerServices;
 
 [assembly: AssemblyTitle("Polly")]
-[assembly: AssemblyVersion("5.6.0.0")]
+[assembly: AssemblyVersion("5.6.1.0")]
 [assembly: CLSCompliant(true)]
 
 [assembly: InternalsVisibleTo("Polly.NetStandard11.Specs")]
diff --git a/src/Polly.SharedSpecs/Caching/AbsoluteTtlSpecs.cs b/src/Polly.SharedSpecs/Caching/AbsoluteTtlSpecs.cs
@@ -6,7 +6,7 @@
 
 namespace Polly.Specs.Caching
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class AbsoluteTtlSpecs : IDisposable
     {
         [Fact]
diff --git a/src/Polly.SharedSpecs/Caching/CacheAsyncSpecs.cs b/src/Polly.SharedSpecs/Caching/CacheAsyncSpecs.cs
@@ -11,7 +11,7 @@
 
 namespace Polly.Specs.Caching
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class CacheAsyncSpecs : IDisposable
     {
         #region Configuration
diff --git a/src/Polly.SharedSpecs/Caching/CacheSpecs.cs b/src/Polly.SharedSpecs/Caching/CacheSpecs.cs
@@ -10,7 +10,7 @@
 
 namespace Polly.Specs.Caching
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class CacheSpecs : IDisposable
     {
         #region Configuration
diff --git a/src/Polly.SharedSpecs/Caching/CacheTResultAsyncSpecs.cs b/src/Polly.SharedSpecs/Caching/CacheTResultAsyncSpecs.cs
@@ -11,7 +11,7 @@
 
 namespace Polly.Specs.Caching
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class CacheTResultAsyncSpecs : IDisposable
     {
         #region Configuration
diff --git a/src/Polly.SharedSpecs/Caching/CacheTResultSpecs.cs b/src/Polly.SharedSpecs/Caching/CacheTResultSpecs.cs
@@ -10,7 +10,7 @@
 
 namespace Polly.Specs.Caching
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class CacheTResultSpecs : IDisposable
     {
         #region Configuration
diff --git a/src/Polly.SharedSpecs/CircuitBreaker/AdvancedCircuitBreakerAsyncSpecs.cs b/src/Polly.SharedSpecs/CircuitBreaker/AdvancedCircuitBreakerAsyncSpecs.cs
@@ -12,7 +12,7 @@
 
 namespace Polly.Specs.CircuitBreaker
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class AdvancedCircuitBreakerAsyncSpecs : IDisposable
     {
         #region Configuration tests
diff --git a/src/Polly.SharedSpecs/CircuitBreaker/AdvancedCircuitBreakerSpecs.cs b/src/Polly.SharedSpecs/CircuitBreaker/AdvancedCircuitBreakerSpecs.cs
@@ -13,7 +13,7 @@
 namespace Polly.Specs.CircuitBreaker
 {
 
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class AdvancedCircuitBreakerSpecs : IDisposable
     {
         #region Configuration tests
diff --git a/src/Polly.SharedSpecs/CircuitBreaker/CircuitBreakerAsyncSpecs.cs b/src/Polly.SharedSpecs/CircuitBreaker/CircuitBreakerAsyncSpecs.cs
@@ -12,7 +12,7 @@
 
 namespace Polly.Specs.CircuitBreaker
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class CircuitBreakerAsyncSpecs : IDisposable
     {
         #region Configuration tests
diff --git a/src/Polly.SharedSpecs/CircuitBreaker/CircuitBreakerSpecs.cs b/src/Polly.SharedSpecs/CircuitBreaker/CircuitBreakerSpecs.cs
@@ -10,7 +10,7 @@
 
 namespace Polly.Specs.CircuitBreaker
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class CircuitBreakerSpecs : IDisposable
     {
         #region Configuration tests
diff --git a/src/Polly.SharedSpecs/CircuitBreaker/CircuitBreakerTResultAsyncSpecs.cs b/src/Polly.SharedSpecs/CircuitBreaker/CircuitBreakerTResultAsyncSpecs.cs
@@ -13,7 +13,7 @@
 
 namespace Polly.Specs.CircuitBreaker
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class CircuitBreakerTResultAsyncSpecs : IDisposable
     {
         #region Configuration tests
diff --git a/src/Polly.SharedSpecs/CircuitBreaker/CircuitBreakerTResultMixedResultExceptionSpecs.cs b/src/Polly.SharedSpecs/CircuitBreaker/CircuitBreakerTResultMixedResultExceptionSpecs.cs
@@ -8,7 +8,7 @@
 
 namespace Polly.Specs.CircuitBreaker
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class CircuitBreakerTResultMixedResultExceptionSpecs : IDisposable
     {
         #region Circuit-breaker threshold-to-break tests
diff --git a/src/Polly.SharedSpecs/CircuitBreaker/CircuitBreakerTResultSpecs.cs b/src/Polly.SharedSpecs/CircuitBreaker/CircuitBreakerTResultSpecs.cs
@@ -12,7 +12,7 @@
 
 namespace Polly.Specs.CircuitBreaker
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class CircuitBreakerTResultSpecs : IDisposable
     {
         #region Configuration tests
diff --git a/src/Polly.SharedSpecs/Helpers/Constants.cs b/src/Polly.SharedSpecs/Helpers/Constants.cs
@@ -0,0 +1,13 @@
+﻿namespace Polly.Specs.Helpers
+{
+    /// <summary>
+    /// Constants supporting tests.
+    /// </summary>
+    public class Constants
+    {
+        /// <summary>
+        /// Denotes a test collection dependent on manipulating the abstracted <see cref="Polly.Utilities.SystemClock"/>.  <remarks>These tests are not parallelized.</remarks>
+        /// </summary>
+        public const string SystemClockDependentTestCollection = "SystemClockDependentTestCollection";
+    }
+}
diff --git a/src/Polly.SharedSpecs/Polly.SharedSpecs.projitems b/src/Polly.SharedSpecs/Polly.SharedSpecs.projitems
@@ -48,6 +48,7 @@
     <Compile Include="$(MSBuildThisFileDirectory)Helpers\Caching\StubErroringCacheProvider.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Helpers\Caching\StubSerialized.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Helpers\Caching\StubSerializer.cs" />
+    <Compile Include="$(MSBuildThisFileDirectory)Helpers\Constants.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Helpers\ContextualPolicyExtensions.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Helpers\ContextualPolicyExtensionsAsync.cs" />
     <Compile Include="$(MSBuildThisFileDirectory)Helpers\ContextualPolicyTResultExtensions.cs" />
diff --git a/src/Polly.SharedSpecs/Retry/WaitAndRetryAsyncSpecs.cs b/src/Polly.SharedSpecs/Retry/WaitAndRetryAsyncSpecs.cs
@@ -13,7 +13,7 @@
 
 namespace Polly.Specs.Retry
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class WaitAndRetryAsyncSpecs : IDisposable
     {
         public WaitAndRetryAsyncSpecs()
diff --git a/src/Polly.SharedSpecs/Retry/WaitAndRetryForeverAsyncSpecs.cs b/src/Polly.SharedSpecs/Retry/WaitAndRetryForeverAsyncSpecs.cs
@@ -12,7 +12,7 @@
 
 namespace Polly.Specs.Retry
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class WaitAndRetryForeverAsyncSpecs : IDisposable
     {
         public WaitAndRetryForeverAsyncSpecs()
diff --git a/src/Polly.SharedSpecs/Retry/WaitAndRetryForeverSpecs.cs b/src/Polly.SharedSpecs/Retry/WaitAndRetryForeverSpecs.cs
@@ -8,7 +8,7 @@
 
 namespace Polly.Specs.Retry
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class WaitAndRetryForeverSpecs : IDisposable
     {
         public WaitAndRetryForeverSpecs()
diff --git a/src/Polly.SharedSpecs/Retry/WaitAndRetryForeverTResultAsyncSpecs.cs b/src/Polly.SharedSpecs/Retry/WaitAndRetryForeverTResultAsyncSpecs.cs
@@ -8,7 +8,7 @@
 
 namespace Polly.Specs.Retry
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class WaitAndRetryForeverTResultAsyncSpecs : IDisposable
     {
         public WaitAndRetryForeverTResultAsyncSpecs()
diff --git a/src/Polly.SharedSpecs/Retry/WaitAndRetryForeverTResultSpecs.cs b/src/Polly.SharedSpecs/Retry/WaitAndRetryForeverTResultSpecs.cs
@@ -7,7 +7,7 @@
 
 namespace Polly.Specs.Retry
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class WaitAndRetryForeverTResultSpecs : IDisposable
     {
         public WaitAndRetryForeverTResultSpecs()
diff --git a/src/Polly.SharedSpecs/Retry/WaitAndRetrySpecs.cs b/src/Polly.SharedSpecs/Retry/WaitAndRetrySpecs.cs
@@ -11,7 +11,7 @@
 
 namespace Polly.Specs.Retry
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class WaitAndRetrySpecs : IDisposable
     {
         public WaitAndRetrySpecs()
diff --git a/src/Polly.SharedSpecs/Retry/WaitAndRetryTResultAsyncSpecs.cs b/src/Polly.SharedSpecs/Retry/WaitAndRetryTResultAsyncSpecs.cs
@@ -8,7 +8,7 @@
 
 namespace Polly.Specs.Retry
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class WaitAndRetryTResultAsyncSpecs : IDisposable
     {
         public WaitAndRetryTResultAsyncSpecs()
diff --git a/src/Polly.SharedSpecs/Retry/WaitAndRetryTResultSpecs.cs b/src/Polly.SharedSpecs/Retry/WaitAndRetryTResultSpecs.cs
@@ -7,7 +7,7 @@
 
 namespace Polly.Specs.Retry
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class WaitAndRetryTResultSpecs : IDisposable
     {
         public WaitAndRetryTResultSpecs()
diff --git a/src/Polly.SharedSpecs/Timeout/TimeoutAsyncSpecs.cs b/src/Polly.SharedSpecs/Timeout/TimeoutAsyncSpecs.cs
@@ -10,7 +10,7 @@
 
 namespace Polly.Specs.Timeout
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class TimeoutAsyncSpecs : TimeoutSpecsBase
     {
         #region Configuration
diff --git a/src/Polly.SharedSpecs/Timeout/TimeoutSpecs.cs b/src/Polly.SharedSpecs/Timeout/TimeoutSpecs.cs
@@ -9,7 +9,7 @@
 
 namespace Polly.Specs.Timeout
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class TimeoutSpecs : TimeoutSpecsBase
     {
         #region Configuration
diff --git a/src/Polly.SharedSpecs/Timeout/TimeoutTResultAsyncSpecs.cs b/src/Polly.SharedSpecs/Timeout/TimeoutTResultAsyncSpecs.cs
@@ -10,7 +10,7 @@
 
 namespace Polly.Specs.Timeout
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class TimeoutTResultAsyncSpecs : TimeoutSpecsBase
     {
         #region Configuration
diff --git a/src/Polly.SharedSpecs/Timeout/TimeoutTResultSpecs.cs b/src/Polly.SharedSpecs/Timeout/TimeoutTResultSpecs.cs
@@ -10,7 +10,7 @@
 
 namespace Polly.Specs.Timeout
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class TimeoutTResultSpecs : TimeoutSpecsBase
     {
         #region Configuration
diff --git a/src/Polly.SharedSpecs/Wrap/PolicyWrapContextAndKeySpecs.cs b/src/Polly.SharedSpecs/Wrap/PolicyWrapContextAndKeySpecs.cs
@@ -5,7 +5,7 @@
 
 namespace Polly.Specs.Wrap
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class PolicyWrapContextAndKeySpecs
     {
         #region PolicyKey and execution Context tests
diff --git a/src/Polly.SharedSpecs/Wrap/PolicyWrapContextAndKeySpecsAsync.cs b/src/Polly.SharedSpecs/Wrap/PolicyWrapContextAndKeySpecsAsync.cs
@@ -7,7 +7,7 @@
 
 namespace Polly.Specs.Wrap
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class PolicyWrapContextAndKeySpecsAsync
     {
         #region PolicyKey and execution Context tests
diff --git a/src/Polly.SharedSpecs/Wrap/PolicyWrapSpecs.cs b/src/Polly.SharedSpecs/Wrap/PolicyWrapSpecs.cs
@@ -9,7 +9,7 @@
 
 namespace Polly.Specs.Wrap
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class PolicyWrapSpecs
     {
         #region Instance configuration syntax tests, non-generic outer
diff --git a/src/Polly.SharedSpecs/Wrap/PolicyWrapSpecsAsync.cs b/src/Polly.SharedSpecs/Wrap/PolicyWrapSpecsAsync.cs
@@ -10,7 +10,7 @@
 
 namespace Polly.Specs.Wrap
 {
-    [Collection("SystemClockDependantCollection")]
+    [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]
     public class PolicyWrapSpecsAsync
     {
         #region Instance configuration syntax tests, non-generic outer

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`
`7`	`7`	`namespace Polly.Specs.Caching`
`8`	`8`	`{`
`9`		`- [Collection("SystemClockDependantCollection")]`
	`9`	`+ [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]`
`10`	`10`	`public class AbsoluteTtlSpecs : IDisposable`
`11`	`11`	`{`
`12`	`12`	`[Fact]`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@`
`11`	`11`
`12`	`12`	`namespace Polly.Specs.Caching`
`13`	`13`	`{`
`14`		`- [Collection("SystemClockDependantCollection")]`
	`14`	`+ [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]`
`15`	`15`	`public class CacheAsyncSpecs : IDisposable`
`16`	`16`	`{`
`17`	`17`	`#region Configuration`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`
`11`	`11`	`namespace Polly.Specs.Caching`
`12`	`12`	`{`
`13`		`- [Collection("SystemClockDependantCollection")]`
	`13`	`+ [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]`
`14`	`14`	`public class CacheSpecs : IDisposable`
`15`	`15`	`{`
`16`	`16`	`#region Configuration`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@`
`12`	`12`
`13`	`13`	`namespace Polly.Specs.CircuitBreaker`
`14`	`14`	`{`
`15`		`- [Collection("SystemClockDependantCollection")]`
	`15`	`+ [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]`
`16`	`16`	`public class AdvancedCircuitBreakerAsyncSpecs : IDisposable`
`17`	`17`	`{`
`18`	`18`	`#region Configuration tests`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`namespace Polly.Specs.CircuitBreaker`
`14`	`14`	`{`
`15`	`15`
`16`		`- [Collection("SystemClockDependantCollection")]`
	`16`	`+ [Collection(Polly.Specs.Helpers.Constants.SystemClockDependentTestCollection)]`
`17`	`17`	`public class AdvancedCircuitBreakerSpecs : IDisposable`
`18`	`18`	`{`
`19`	`19`	`#region Configuration tests`