SLVSCODE-1096 check for undefined before binding creation

sophio-japharidze-sonarsource · web-flow · commit 370fd0630e1a · 2025-04-08T16:03:49.000+02:00
diff --git a/src/connected/binding.ts b/src/connected/binding.ts
@@ -177,7 +177,7 @@ export class BindingService {
   }
   
   isRelatedConnectionValid(connectionId: string) : boolean {
-    return this.settingsService.getStatusForConnection(connectionId).success;
+    return this.settingsService.getStatusForConnection(connectionId)?.success ?? false;
   }
   
   async getBaseServerUrl(connectionId: string, serverType: ServerType): Promise<string> {

Original file line number	Diff line number	Diff line change
`@@ -177,7 +177,7 @@ export class BindingService {`
`177`	`177`	`}`
`178`	`178`
`179`	`179`	`isRelatedConnectionValid(connectionId: string) : boolean {`
`180`		`- return this.settingsService.getStatusForConnection(connectionId).success;`
	`180`	`+ return this.settingsService.getStatusForConnection(connectionId)?.success ?? false;`
`181`	`181`	`}`
`182`	`182`
`183`	`183`	`async getBaseServerUrl(connectionId: string, serverType: ServerType): Promise<string> {`