Skip to content

Commit 2c2a0f5

Browse files
authored
Add move constructor and assignment to {ROOT,RNTuple}{Reader,Writer} (#943)
Co-authored-by: Juan Miguel Carceller <[email protected]>
1 parent 3528b41 commit 2c2a0f5

4 files changed

Lines changed: 9 additions & 12 deletions

File tree

include/podio/RNTupleReader.h

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,13 @@ namespace root_compat {
3535
class RNTupleReader {
3636

3737
public:
38-
/// Create a RNTupleReader
3938
RNTupleReader() = default;
40-
/// Destructor
4139
~RNTupleReader() = default;
42-
/// The RNTupleReader is not copy-able
40+
4341
RNTupleReader(const RNTupleReader&) = delete;
44-
/// The RNTupleReader is not copy-able
4542
RNTupleReader& operator=(const RNTupleReader&) = delete;
43+
RNTupleReader(RNTupleReader&&) = default;
44+
RNTupleReader& operator=(RNTupleReader&&) = default;
4645

4746
/// Open a single file for reading.
4847
///

include/podio/RNTupleWriter.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,10 @@ class RNTupleWriter {
5252
/// able to read files back again.
5353
~RNTupleWriter();
5454

55-
/// The RNTupleWriter is not copy-able
5655
RNTupleWriter(const RNTupleWriter&) = delete;
57-
/// The RNTupleWriter is not copy-able
5856
RNTupleWriter& operator=(const RNTupleWriter&) = delete;
57+
RNTupleWriter(RNTupleWriter&&) = default;
58+
RNTupleWriter& operator=(RNTupleWriter&&) = default;
5959

6060
/// Store the given frame with the given category.
6161
///

include/podio/ROOTReader.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -49,15 +49,13 @@ struct CollectionReadBuffers;
4949
class ROOTReader {
5050

5151
public:
52-
/// Create a ROOTReader
5352
ROOTReader() = default;
54-
/// Destructor
5553
~ROOTReader() = default;
5654

57-
/// The ROOTReader is not copy-able
5855
ROOTReader(const ROOTReader&) = delete;
59-
/// The ROOTReader is not copy-able
6056
ROOTReader& operator=(const ROOTReader&) = delete;
57+
ROOTReader(ROOTReader&&) = default;
58+
ROOTReader& operator=(ROOTReader&&) = default;
6159

6260
/// Open a single file for reading.
6361
///

include/podio/ROOTWriter.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,10 @@ class ROOTWriter {
4040
/// This also takes care of writing all the necessary metadata to read files back again.
4141
~ROOTWriter();
4242

43-
/// The ROOTWriter is not copy-able
4443
ROOTWriter(const ROOTWriter&) = delete;
45-
/// The ROOTWriter is not copy-able
4644
ROOTWriter& operator=(const ROOTWriter&) = delete;
45+
ROOTWriter(ROOTWriter&&) = delete;
46+
ROOTWriter& operator=(ROOTWriter&&) = delete;
4747

4848
/// Store the given frame with the given category.
4949
///

0 commit comments

Comments
 (0)